Permissions for branch_transfer_limits.pl are defined as "flagsrequired => {borrowers => 1}." This makes the page accessible to any user with permission to add or modify patrons. Based on the other admin scripts, the correct setting appears to be "parameters => 'parameters_remaining_permissions'"
Created attachment 29658 [details] [review] Bug 8539: Library transfer limits page has incorrect permission Without this patch the library transfer page required the 'borrowers' permission, which is not quite right for a page in the administration module. This patch changes the permission to 'parameters_remaining_permissions' To test: Verify the page is accessbile with: - superlibrarian - administration (full) - administration, remaining permissions (without manage_circ_rules) Verify the page is not accessible without all of those permissions.
Created attachment 30645 [details] [review] [SIGNED OFF] Bug 8539: Library transfer limits page has incorrect permission Without this patch the library transfer page required the 'borrowers' permission, which is not quite right for a page in the administration module. This patch changes the permission to 'parameters_remaining_permissions' To test: Verify the page is accessbile with: - superlibrarian - administration (full) - administration, remaining permissions (without manage_circ_rules) Verify the page is not accessible without all of those permissions. Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Thx Nick!
Created attachment 30859 [details] [review] [PASSED QA] Bug 8539: Library transfer limits page has incorrect permission Without this patch the library transfer page required the 'borrowers' permission, which is not quite right for a page in the administration module. This patch changes the permission to 'parameters_remaining_permissions' To test: Verify the page is accessbile with: - superlibrarian - administration (full) - administration, remaining permissions (without manage_circ_rules) Verify the page is not accessible without all of those permissions. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Katrin!
Pushed to 3.16.x for inclusion in 3.16.3.