Bug 8546 - Error in description of OPAC Advanced Search Publication date range search
Summary: Error in description of OPAC Advanced Search Publication date range search
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 08:57 UTC by Kari Blomster
Modified: 2013-12-05 20:01 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8546 - Error in description of OPAC Advanced Search Publication date range search (1.38 KB, patch)
2012-11-02 18:53 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed off] Bug 8546 - Error in description of OPAC Advanced Search Publication date range search (1.40 KB, patch)
2012-11-08 00:18 UTC, Melia Meggs
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kari Blomster 2012-08-01 08:57:07 UTC
Guide text in the advanced search form is incorrect: 

"For example: 1999-2001. You could also use "-1987" for everything published before 1987 or "2008-" for everything published after 2008." is illogical. 

The logically and functionally correct way being: 
For example: 1999-2001. You could also use "-1987" for everything published before 1988 or "2008-" for everything published after 2007.

Reproducing the bug: 
Search date range 2008- for "everything published _after_2008_" and you'll get also books published 2008, not only after 2008. 
@
http://catalog.farmingtonlibraries.org/cgi-bin/koha/opac-search.pl

This text bug prevails in community's demo runs 3.8, 3.6, 3.2 and master, provided by Bywater, CALYX, Equinox, Libriotech, software.coop
http://koha-community.org/demo/
The four TOF demo Opacs on the list. 

Also in Bywater sandbox OPAC
http://catalog.bywatersolutions.com/
EVEN THOUGH text bug has been fixed in Bywater sandbox Intranet (ver.3.09.00.026, whatever that would mean) (login bywater - bywater reqrd): 
http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl

Bug shows in live instances too, e.g. Farmington Koha, 
http://catalog.farmingtonlibraries.org/cgi-bin/koha/opac-search.pl

Most likely in KOHA 3.10 too. 

FIX SUGEGSTION, that do not age along the years: like w Bywater 

format: yyyy-yyyy


PS.
All in all, when I "patron-eyed" Farmington Adv search, I started to miss guide text feature. The advSearch page is so long. 
It could be shortened. Esp. the Item type list should be made drop-down type and also divided into 2 or more categories: Item types and thematical types. Or newest item types? Now the list doesn't work for, well, anybody. Schratching here my head: some patrons could use this as an itemtype browsing feature. (Well but this is now off-topic already.)
Comment 1 Owen Leonard 2012-11-02 18:53:55 UTC Comment hidden (obsolete)
Comment 2 Melia Meggs 2012-11-08 00:18:27 UTC
Created attachment 13296 [details] [review]
[Signed off] Bug 8546 - Error in description of OPAC Advanced Search Publication date range search

The publication date range search description in the OPAC suggests
that a search like "-1987" or "2008-" is not inclusive when it
actually is. This patch corrects the description.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Comment 3 Melia Meggs 2012-11-08 00:19:49 UTC
Tested this patch, and the new description showed up fine on Advanced Search.  It seems much clearer now, so I am signing off.
Comment 4 Jonathan Druart 2012-11-19 15:02:45 UTC
QA Comments:
Simple patch. 1 template line changed.
Marked as Passed QA
Comment 5 Jared Camins-Esakov 2012-11-23 18:10:42 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2012-11-26 02:41:55 UTC
Pushed to 3.10.x will be in 3.10.1
Comment 7 Chris Cormack 2012-11-26 07:42:41 UTC
Pushed to 3.8.x, will be in 3.8.8
Comment 8 Liz Rea 2012-11-28 00:59:40 UTC
Patch does not apply to 3.6.x - please attach a 3.6 patch if required.

Thanks!