Copy cataloging via Z39.50 is often done by searching on ISBN or ISSN. Unfortunately, the code for doing this is... problematic, and may cause problems with some Z39.50 servers.
Created attachment 11273 [details] [review] Bug 8550: Z39.50 searches for ISBN/ISSN problematic Rather than treating ISBN and ISSN as the same, this patch breaks them out into separate parts of the query, as well as changing the truncation attribute to enable right truncation (the correct behavior for the ISBN field in MARC21, and valid behavior in UNIMARC).
(In reply to comment #1) > Created attachment 11273 [details] [review] > Bug 8550: Z39.50 searches for ISBN/ISSN problematic I finally got koha running off my git install and applied the patch. It works! :-)
Created attachment 11304 [details] [review] Bug 8550: Z39.50 searches for ISBN/ISSN problematic - Signed Off
(In reply to comment #3) > Created attachment 11304 [details] [review] > Bug 8550: Z39.50 searches for ISBN/ISSN problematic - Signed Off > Signed-off-by: Joseph Alway <jbalway@gmail.com> patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * bc4a87d Bug 8550: Z39.50 searches for ISBN/ISSN problematic cataloguing/z3950_search.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK
Pushed to 3.8.x, will be in 3.8.4 Thank you very much for your sign off Joseph
Patch pushed (Joseph Alway, if I'm not mistaking, it's your 1st signoff = congratulations & welcomed !)
mmm... maybe i've be a little to fast in pushing this patch: Jared, in z3950_search.pl, I see: <li><label for="isbn">ISBN/ISSN: </label> <input type="text" id="isbn" name="isbn" value="[% isbn %]" /></li> There is no field called issn, so $query->param('issn') is always empty and that's some dead code (which was partially already here before, I agree) Am I right or do I have missed something ? (however, patch already pushed, but please answer -and provide a fix if needed !-)
Created attachment 11936 [details] [review] Bug 8550: restore ISSN field to Z39.50 search Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search page, and the ISBN field replaced with a combined ISBN/ISSN field. Since this breaks ISBN search for most Z39.50 targets (due to the differing treatment of ISBN vs. ISSN), this is a bug not a feature. A future enhancement would be to use Business::ISBN to search for both ISBN10 and ISBN13. To test: 1) Apply patch. 2) Do a search for an ISBN using the ISBN field. 3) Do a search for an ISSN using the ISSN field.
Paul, What you were missing was the second patch for this bug, which I failed to attach. I have now done so.
Simple patch, provides the last of the clean up needed to undo a regression.
Created attachment 11940 [details] [review] Bug 8550: restore ISSN field to Z39.50 search Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search page, and the ISBN field replaced with a combined ISBN/ISSN field. Since this breaks ISBN search for most Z39.50 targets (due to the differing treatment of ISBN vs. ISSN), this is a bug not a feature. A future enhancement would be to use Business::ISBN to search for both ISBN10 and ISBN13. To test: 1) Apply patch. 2) Do a search for an ISBN using the ISBN field. 3) Do a search for an ISSN using the ISSN field. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(In reply to comment #11) > Created attachment 11940 [details] [review] > Bug 8550: restore ISSN field to Z39.50 search > > Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search > page, and the ISBN field replaced with a combined ISBN/ISSN field. Since > this breaks ISBN search for most Z39.50 targets (due to the > differing treatment of ISBN vs. ISSN), this is a bug not a feature. > > A future enhancement would be to use Business::ISBN to search for both > ISBN10 and ISBN13. > > To test: > 1) Apply patch. > 2) Do a search for an ISBN using the ISBN field. > 3) Do a search for an ISSN using the ISSN field. > > Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit ec365ff) * 301dd72 Bug 8550: restore ISSN field to Z39.50 search koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK - t/00-valid-xml.t tests... OK
All of the same problems exist in the file /usr/share/koha/intranet/cgi-bin/acqui/z3950_search.pl as noted in bug 8680.
Follow-up pushed to master (thx jared)
Pushed to 3.8.x, will be in 3.8.5
*** Bug 8254 has been marked as a duplicate of this bug. ***
This is working in Master.
Comment on attachment 11304 [details] [review] Bug 8550: Z39.50 searches for ISBN/ISSN problematic - Signed Off The first patch was obsoleted, but is needed for folks doing a git bz apply for versions older than 3.8.4 (which hopefully they shouldn't need to do, but still...)