When importing frameworks using open office or another program a confirmation message asks you, if you are really sure you want to overwrite the existing framework, fields and subfields. It would be nice, if this message showed which framework you are going to overlay, because this is not visible from the page or the message at the moment.
*** Bug 8789 has been marked as a duplicate of this bug. ***
At the moment, the message is: "Do you really want to import the framework fields/subfields (will overwrite current configuration, for safety reasons please make before an export to have a backup file)?" This could probably benefit from some proofreading too. :-)
Is this still valid? The message on the latest version is: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" And when you click Import on a framework, it says "Import [% frameworkcode %] framework structure (fields and subfields) from a spreadsheet file (.csv, .xml, .ods)" at the top of the box so you know which one you're overwriting.
The framework is still not visible in the first modal, small change, but could be really helpful.
Created attachment 88997 [details] [review] Bug 8558: Improve confirmation message for importing frameworks This patch updates the confirmation message from: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" to: "Are you sure you want to import the [% loo.frameworkcode | html %] framework structure? This will overwrite the current configuration. For safety reasons, it is recommended to use the export option to make a backup first." To test: 1) Go to Administration -> MARC bibliographic frameworks 2) Export one of the frameworks 3) Create a new test framework 4) Import the new test framework structure using the exported file 5) Upon clicking Confirm, confirm the message is improved and makes sense. Sponsored-by: Catalyst IT
The framework code shown in the confirmation message is not the same as the chosen framework to overwrite. It always shows the code for the last framework in the list.
Created attachment 89366 [details] [review] Bug 8558: Improve confirmation message for importing frameworks This patch updates the confirmation message from: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" to: "Are you sure you want to import the [% frameworkcode %] framework structure? This will overwrite the current configuration. For safety reasons, it is recommended to use the export option to make a backup first." To test: 1) Go to Administration -> MARC bibliographic frameworks 2) Export one of the frameworks 3) Create a new test framework 4) Import the new test framework structure using the exported file 5) Upon clicking Confirm, confirm the message is improved and makes sense. Sponsored-by: Catalyst IT
(In reply to Maryse Simard from comment #6) > The framework code shown in the confirmation message is not the same as the > chosen framework to overwrite. It always shows the code for the last > framework in the list. Fixed, please retest
Created attachment 89489 [details] [review] Bug 8558: Improve confirmation message for importing frameworks This patch updates the confirmation message from: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" to: "Are you sure you want to import the [% frameworkcode %] framework structure? This will overwrite the current configuration. For safety reasons, it is recommended to use the export option to make a backup first." To test: 1) Go to Administration -> MARC bibliographic frameworks 2) Export one of the frameworks 3) Create a new test framework 4) Import the new test framework structure using the exported file 5) Upon clicking Confirm, confirm the message is improved and makes sense. Sponsored-by: Catalyst IT Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89490 [details] [review] Bug 8558: (QA follow-up) a little more text clean up You can take or leave it, honestly, I just thought we could be a little more explicit about what we were overwriting. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89491 [details] [review] Bug 8558: (QA follow-up) a little more text clean up You can take or leave it, honestly, I just thought we could be a little more explicit about what we were overwriting.
I just realized that with the modal staying in the background this is already a bit better than it used to be, because you can see the framework code there as well :)
Created attachment 89587 [details] [review] Bug 8558: Improve confirmation message for importing frameworks This patch updates the confirmation message from: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" to: "Are you sure you want to import the [% frameworkcode %] framework structure? This will overwrite the current configuration. For safety reasons, it is recommended to use the export option to make a backup first." To test: 1) Go to Administration -> MARC bibliographic frameworks 2) Export one of the frameworks 3) Create a new test framework 4) Import the new test framework structure using the exported file 5) Upon clicking Confirm, confirm the message is improved and makes sense. Sponsored-by: Catalyst IT Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 89588 [details] [review] Bug 8558: (QA follow-up) a little more text clean up You can take or leave it, honestly, I just thought we could be a little more explicit about what we were overwriting. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.01
backported to 18.11.x for 18.11.07