8572 – Attempting to view an invalid authority in the OPAC gives an error instead of 404

Bug 8572 - Attempting to view an invalid authority in the OPAC gives an error instead of 404

Summary: Attempting to view an invalid authority in the OPAC gives an error instead of...

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	OPAC (show other bugs)
Version:	3.8
Hardware:	All All

Importance:	P5 - low major
Assignee:	Jared Camins-Esakov
QA Contact:	Jonathan Druart

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-08-04 17:39 UTC by Jared Camins-Esakov
Modified:	2013-12-05 20:01 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8572: invalid auth shouldn't cause error (1.91 KB, patch) 2012-08-04 17:44 UTC, Jared Camins-Esakov	Details \| Diff \| Splinter Review
Bug 8572: invalid auth shouldn't cause error (1.93 KB, patch) 2012-08-06 07:58 UTC, Chris Cormack	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jared Camins-Esakov 2012-08-04 17:39:49 UTC

Comment 1 Jared Camins-Esakov 2012-08-04 17:44:29 UTC Comment hidden (obsolete)

Created attachment 11358 [details] [review]
Bug 8572: invalid auth shouldn't cause error

Prior to this patch, attempting to view an invalid authority in the
OPAC gave a system error instead of a 404. With this patch, the user
will just get a 404, as is the case with invalid bibs.

To test:
1) Try to view an invalid authority by going to:
   /cgi-bin/koha/opac-authoritiesdetail.pl?authid=999999999999
   (presuming that you don't have an authority with authid 999999999999
   in your database) before and after applying this patch

Comment 2 Chris Cormack 2012-08-06 07:58:08 UTC

Created attachment 11371 [details] [review]
Bug 8572: invalid auth shouldn't cause error

Prior to this patch, attempting to view an invalid authority in the
OPAC gave a system error instead of a 404. With this patch, the user
will just get a 404, as is the case with invalid bibs.

To test:
1) Try to view an invalid authority by going to:
   /cgi-bin/koha/opac-authoritiesdetail.pl?authid=999999999999
   (presuming that you don't have an authority with authid 999999999999
   in your database) before and after applying this patch

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Comment 3 Jonathan Druart 2012-08-09 10:06:54 UTC

QA comments:

It would have been more user-friendly to display an adapted error for this case. But Koha does not have a simply way to send messages (infos, warnings, errors) to the templates.

So, I mark as Passed QA

Comment 4 Chris Cormack 2012-08-09 10:19:30 UTC

Pushed to 3.8.x, will be in 3.8.4

Comment 5 Paul Poulain 2012-08-29 13:07:14 UTC

Patch pushed to master