Created attachment 11391 [details] [review] Bug 8581: don't display parentheses when we don't have a type Prior to this patch, see also references in certain authority records (most notably GND records) were being followed by empty parentheses in the search results display. This patch resolves that problem.
Created attachment 11395 [details] [review] Bug 8581: don't display parentheses when we don't have a type Prior to this patch, see also references in certain authority records (most notably GND records) were being followed by empty parentheses in the search results display. This patch resolves that problem. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(In reply to comment #2) > Created attachment 11395 [details] [review] > Bug 8581: don't display parentheses when we don't have a type > > Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> patch looks good, passing QA *NOTE: PATCH MUST BE APPLIED AFTER 3462* mason@xen1:~/git/head$ git bz apply 3462 Bug 3462 - Link see alsos in authorities Bug 3462: Links in authorities should be hyperlinks Apply? [yn] y Applying: Bug 3462: Links in authorities should be hyperlinks mason@xen1:~/git/head$ git bz apply 8581 Bug 8581 - Authority display doesn't like GND records Bug 8581: don't display parentheses when we don't have a type Apply? [yn] y Applying: Bug 8581: don't display parentheses when we don't have a type mason@xen1:~/git/head$ mason@xen1:~/git/head$ koha-qa.pl * 645650a Bug 8581: don't display parentheses when we don't have a type koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK mason@xen1:~/git/head$
Pushed to stable
sorry, save hit too fast... The patch does not apply. Looking at koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc I see that the patch says: - [% CASE %]([% type | html %]) + [% CASE %][% IF type %]([% type | html %])[% END %] and I have: [% CASE %]([% type %]) (not type|html) WTF ?
Hi Jared, can you take a look at this please?
Setting back to "Passed QA" as the patch applies fine on current master.
Patch pushed to master
Could you please rebase this for 3.8.x
Created attachment 12630 [details] [review] [3.8.x] Bug 8581: don't display parentheses when we don't have a type Prior to this patch, see also references in certain authority records (most notably GND records) were being followed by empty parentheses in the search results display. This patch resolves that problem. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Patch rebased for 3.8.x attached.
Pushed to 3.8.x, will be in 3.8.6
This has been fixed in Master.