Created attachment 11392 [details] [review] Add a warning if a Z39.50 search is started from biblio edition page. If the "Z39.50 Search" is clicked when editing an existing biblio record, the current record will be overwritten by the imported Z39.50 record. This patch simply adds a warning when the button is clicked so the user is aware that doing a Z39.50 import from the edition page will overwrite the current record.
Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )
Owen had a good suggestion. Rather than adding an additional click every time someone clicks the "Z39.50 Search" button, perhaps we could change the label to something like "Replace with Z39.50"?
Created attachment 12026 [details] [review] [SIGNED-OFF] Add a warning if a Z39.50 search is started from biblio edition page. Warn the user that the current biblio record might be overwritten by this action. http://bugs.koha-community.org/show_bug.cgi?id=8583 Signed-off-by: Marc Veron <veron@veron.ch> Woks as expected. I prefer this solution with an explicit warning, since several times I acidentally changed a record :-)
QA comment: * tiny patch, no side effect risk * passes koha-qa.pl passed QA Question: why does the message say: "could replace" ? It "will" replace isn't it ?
Patch pushed to master. More a minor bugfix than an ENH, but chris, up to you, as usual
Pushed to 3.8.x will be in 3.8.6
I am not sure I like this change - actually I think it's a bit annoying for an experienced cataloger. Wouldn't it be better to change the button labelling maybe? It could say "Z39.50 overlay" or something else that makes sense in English. Also, the prompt always appears, even for a totally empty that has not been saved yet. It's totally unnecessary in this case.
I have filed a separate bug - maybe we can just make it appear a bit less often by eliminiating the prompt for a new record (bug 9742)? I understand the idea behind this - I was only taken a bit by surprise today when testing something else.