If a framework does not have a biblio.biblionumber mapping, cataloguing dies saying : No biblionumber tag for framework "$frameworkcode". It is the same for biblioitems.biblioitemnumber. But the code uses the biblio tag var instead of biblioitem tag. This causes on cataloguing with this framework the message : Software error: Tag "0" is not a valid tag. at /home/koha/src/C4/Biblio.pm line 3138 Very small patch.
Created attachment 11414 [details] [review] Proposed patch
Test plan : ----------- Create a new framework using default one. Delete subfield definition mapped on biblioitems.biblioitemnumber. Create a new record using this framework. Without patch => software error With patch => error message
Created attachment 11461 [details] [review] Bug 8586: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(In reply to comment #3) > Created attachment 11461 [details] [review] > Bug 8586: Small bug in die if no mapping in framework for > biblioitems.biblioitemnumber > > Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * 4481197 Bug 8586: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber C4/Biblio.pm - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK
Pushed to 3.8.x, will be in 3.8.4
Patch pushed to master. Already in stable, setting status accordingly.