When the SQL repots template displays form fields for entering runtime parameters the fields do not have unique ids. This prevents correct label+input markup from being possible and causes buggy behavior by the jQueryUI datepicker widget.
Created attachment 11426 [details] [review] Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry Changes to markup and script to enable unique ids on form fields. These changes allow for working label+input pairs on one or more text and select inputs and multiple working datepickers. To test, create a report with more than one date parameter, at least one text parameter, and one or more authorised value parameters. The datepickers should each work properly, and labels should by clickable.
Created attachment 11438 [details] [review] Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry Changes to markup and script to enable unique ids on form fields. These changes allow for working label+input pairs on one or more text and select inputs and multiple working datepickers. To test, create a report with more than one date parameter, at least one text parameter, and one or more authorised value parameters. The datepickers should each work properly, and labels should by clickable. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
(In reply to comment #2) > Created attachment 11438 [details] [review] > Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry > > Changes to markup and script to enable unique ids on form > fields. These changes allow for working label+input pairs > on one or more text and select inputs and multiple working > datepickers. > > To test, create a report with more than one date parameter, > at least one text parameter, and one or more authorised > value parameters. The datepickers should each work properly, > and labels should by clickable. > > Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * b23ef0a Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt reports/guided_reports.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK
Patch pushed today
Does not apply to 3.8.x, please submit a patch for 3.8.x if you think it should be pushed there.
Created attachment 13608 [details] [review] Bug 8588 [3.8.x] Duplicate field IDs cause problems with SQL report parameter entry Reimplemented for 3.8.x: Changes to markup and script to enable unique ids on form fields. These changes allow for working label+input pairs on one or more text and select inputs and multiple working datepickers. To test, create a report with more than one date parameter, at least one text parameter, and one or more authorised value parameters. The datepickers should each work properly, and labels should by clickable.
Pushed to 3.8.x, will be in 3.8.8