Created attachment 11436 [details] [review] edited intranet-main file
Created attachment 11442 [details] [review] [SIGNED-OFF] Bug 8593 - Add unique IDs to pending approval markup on staff client home page edited the intranet main-tt file. updated "suggestions pending". (w box) http://bugs.koha-community.org/show_bug.cgi?id=8593 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 11443 [details] [review] Bug 8593 - Follow-up - Add unique IDs to pending approval markup on staff client home page This patch adds similar IDs to the tags and comments <div>
Created attachment 11462 [details] [review] edited intranet-main file (box version) version of home page with edited suggestions pending w box around "suggestions pending"
Created attachment 11463 [details] [review] edited intranet-main file (without box version) Main staff page css script. Version of suggestions pending layout 2. (without box surrounding "suggestions pending"
Created attachment 11464 [details] [review] [SIGNED-OFF] Bug 8593 - Follow-up - Add unique IDs to pending approval
Created attachment 11466 [details] [review] bug 8593: css file for the box version of "suggestions pending"
Created attachment 11468 [details] [review] Bug 8593. css script version of "suggestions pending" without box
I am confused by the patches on this bug. Does one (or more) supersede one (or more) of the others? It seems like the second two might be alternatives, where one or the other can be used, but not both. Is this true? Which one is being proposed for inclusion in Koha?
The first 2 are needed, then they next 2 are alternatives we can't decide which look we prefer.
Created attachment 11613 [details] Screenshot of CSS option 1
Created attachment 11616 [details] Screenshot of CSS option 2
I prefer the display as we have it now. The markup updates makes it easy for someone to add their own custom style to these links, and I think we should leave it at that for now.
I'm going to mark this as "signed off" so that the first couple of patches can go through QA. If anyone wants to argue for the inclusion of one of the attached CSS revisions they can comment and add their signoff.
First two patches are template only changes adding IDs to tags. Marking them Passed QA. The debate of what CSS styling to do with them can be resolved separately.
(In reply to comment #14) > First two patches are template only changes adding IDs to tags. Marking > them Passed QA. The debate of what CSS styling to do with them can be > resolved separately. I agree with Owen, and this we don't need to push more than the 2 first patches. 2 patch pushed
With the css, this drops back to a bug fix. Adding ids allows people to style the page with no risk of any harm. Pushed to 3.8.x, will be in 3.8.5