If you create a report with <<Enter a date|date>>, the resulting date picker interface when running the report doesn't force dates to ISO form, instead they are created using the date format of the system. This is passed to mysql which complains about the format not being right, understandably.
Created attachment 11605 [details] [review] Bug 8596 - Reports interface date picker doesn't force ISO formatted dates Datepickers follow Koha's preference for date format, but the guided reports system doesn't intelligently handle different date formats. ISO is required. This patch adds some additional configuration to override the date format. To test, create a guided or SQL report which takes a date parameter. The datepicker fields should return an ISO-formatted date.
Created attachment 11645 [details] [review] [SIGNED-OFF] Bug 8596 - Reports interface date picker doesn't force ISO formatted dates Datepickers follow Koha's preference for date format, but the guided reports system doesn't intelligently handle different date formats. ISO is required. This patch adds some additional configuration to override the date format. To test, create a guided or SQL report which takes a date parameter. The datepicker fields should return an ISO-formatted date. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as advertised.
Adds date formatting according to datepicker's conventions (which do yyyy-mm-dd even though it says yy-mm-dd). Passed QA.
QA It would have been better to handle the syspref properly, but I agree it would have required a larger rewrite. And, as we're dealing with reports/sql/..., which is used by a limited number of patrons, I agree it's fair to force iso. Patch pushed
Pushed to 3.8.x will be in 3.8.5