Bug 8606 - Talking Tech broken by user-configurable slips feature
Summary: Talking Tech broken by user-configurable slips feature
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 11:55 UTC by Kyle M Hall
Modified: 2013-12-05 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8606 - Talking Tech broken by Bug 7001 (3.08 KB, patch)
2012-08-09 11:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8606 - Talking Tech broken by Bug 7001 (2.53 KB, patch)
2012-08-09 11:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8606 - Talking Tech broken by Bug 7001 (2.59 KB, patch)
2012-08-24 23:30 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup (1.27 KB, patch)
2012-09-19 15:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup (733 bytes, patch)
2012-09-19 15:54 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2012-08-09 11:55:29 UTC
The patches for bug 7001 removed the parseletter subroutine from C4::Letters without updating the talking tech script to use the new alternative.
Comment 1 Kyle M Hall 2012-08-09 11:56:47 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-08-09 11:58:44 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2012-08-24 23:30:24 UTC
Created attachment 11830 [details] [review]
Bug 8606 - Talking Tech broken by Bug 7001

The patches for bug 7001 removed the parseletter subroutine from
C4::Letters without updating the talking tech script to use the
new alternative. This patch rectifies that situation.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 4 Jonathan Druart 2012-09-19 13:58:28 UTC
QA Comments:
No side effect possible. I don't tested the patch but it seems good.

No blocker:
* C4/Letters.pm FAIL
  forbidden patterns FAIL
    The patch introduces a forbidden pattern: withespace character  (156)

But I don't understand why do you use the | operator. I think you wanted to use the || operator and wrote
  $branchcode ||= '';
Comment 5 Kyle M Hall 2012-09-19 15:53:46 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2012-09-19 15:54:56 UTC
Created attachment 12360 [details] [review]
Bug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup
Comment 7 Kyle M Hall 2012-09-19 15:55:56 UTC
(In reply to comment #4)
> QA Comments:
> No side effect possible. I don't tested the patch but it seems good.
> 
> No blocker:
> * C4/Letters.pm FAIL
>   forbidden patterns FAIL
>     The patch introduces a forbidden pattern: withespace character  (156)
> 
> But I don't understand why do you use the | operator. I think you wanted to
> use the || operator and wrote
>   $branchcode ||= '';

You are correct. The smallest followup ever written has been attached ; )
Comment 8 Jonathan Druart 2012-09-20 07:27:37 UTC
(In reply to comment #7)
> You are correct. The smallest followup ever written has been attached ; )

Thank you Kyle.
So I mark it as Passed QA.
Comment 9 Paul Poulain 2012-09-20 13:00:24 UTC
Patch pushed to master

I thin it's more a bugfix than en ENH. Switching to "normal" severity, probably expected for 3.8
Comment 10 Chris Cormack 2013-04-20 22:45:26 UTC
Released in 3.10.0 (not needed in 3.8.x)