I send myself a cart from the English and from the German templates, both emails show wrong formatting. I sent 2 titles, one with, one without items. Then numbering is wrong: Hi, Katrin Fischer sent you a cart from our online catalog. Please note that the attached file is a MARC bibliographic records file which can be imported into personal bibliographic software like EndNote, Reference Manager or ProCite. --------------------------------------------------------------------- 1. Allgemeine deutsche Biographie / * Author(s): Bayerische Akademie der Wissenschaften --Historische Kommission * Published by: Duncker & Humblot,, 54 * Notes : Zitiert.: ADB. - Neudr. mit Ersch.-Ort Berlin. - In Fraktur * Items: 2. Veröffentlichungen des Max-Planck-Instituts für Geschichte 3. Published by: Vandenhoeck & Ruprecht, 54 4. URL : http://www.bsz-bw.de/rekla/show.php?mode=urce&id2 5. Items: * Midway (non public note testing) dia
The new template is also missing a link to the catalog. In HTML format the title would be linked, but when converting it to text, the link gets lost.
Ok, I tried bringing back the links to the OPAC, but I have run into a bigger issue with html2text. If the link is longer than the line width, the link is cut off. Result looks like this: * In the online catalog: http://localhost/cgi-bin/koha/opac-detail.pl?biblionumber So even with a short URL we got a problem here. :(
Created attachment 11562 [details] [review] Bug 8621: Fix formatting in cart email - Reformatted template for better readability and to find missing element - Added missing </li> - Added check for existance of items, so 'Items:' is only printed, if there are items To test: - Add several records to the cart, add items with and without items - Send yourself the cart as email and check formatting - Update po files for any language, translate the po file for OPAC and install language - Send yourself the cart email again from the translated templates, check formatting
I filed bug 8628 for the URL problem - turns out it's not the length but = being part of the URL that is causing the problem.
Created attachment 11593 [details] [review] Bug 8621: Alternative template for cart email - uses less list elements, in favour of paragraphs and line breaks - reimplements a link to the opac for each record Note: In order for the URLs to be correct this needs to be tested together with the patch for bug 8626. To test: - Add several records to the cart, add items with and without items - Send yourself the cart as email and check formatting - Update po files for any language, translate the po file for OPAC and install language - Send yourself the cart email again from the translated templates, check formatting
Hi, first patch only fixes a problem in the existing template, second patch is an alternative and should not be applied on top of the first, but separately. Looking for sign-offs and feedback :)
Created attachment 11609 [details] [review] Bug 8621: Alternative template for cart email - uses less list elements, in favour of paragraphs and line breaks - reimplements a link to the opac for each record Note: In order for the URLs to be correct this needs to be tested together with the patch for bug 8626. To test: - Add several records to the cart, add items with and without items - Send yourself the cart as email and check formatting - Update po files for any language, translate the po file for OPAC and install language - Send yourself the cart email again from the translated templates, check formatting Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Template only change, fixing indenting and other issues. Easy to read, passed QA.
Patch pushed, some comments: * I couldn't check that the mail is OK, because my test installation does not send email. So trusting signoff. * Can't decide if it's an ENH or a bugfix. Not switching to ENH, and letting RMaint decide * Katrin, shouldn't we do the same think on staff basket sending as well (modules/basket/sendbasket.tt) ?
Hi Paul, both staff cart and sending lists need more work, but I haven't had time to replicate the recent changes to the cart email templates to the lists and staff interface. Happy if somemone beats me to it (see bug 8062)
Pushed to 3.8.x, will be in 3.8.5