Within field 008 pipe values (i.e. character | ) were not passed correctly in the plugin script value_builder/marc21_field_008_authorities.pl to the template, resulting in replacement of these character positions. Attached patch handles them correctly. Test this in Add/Edit authorities (staff) by: 1 Without patch: Put | at the last position of 008 manually (overwrite last character). Click plugin (tag editor). Look at position 039 and click OK. You should have lost the pipe character. 2 With patch. Again put | at the end (overwrite last character). Goto tag editor and look at pos 39. Click OK. You should still have a pipe char. 3 Sign off.
Created attachment 11572 [details] [review] Patch
Created attachment 11573 [details] [review] Followup for replacing tabs
Created attachment 11637 [details] [review] [SIGNED-OFF] 8627 Fixing pipe values in controlfield 008 authorities Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 11638 [details] [review] [SIGNED-OFF] 8627 Followup for removing tabs Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Works as expected.
> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit a64c811) * 6dee396 8627 Followup for removing tabs cataloguing/value_builder/marc21_field_008_authorities.pl * cataloguing/value_builder/marc21_field_008_authorities.pl OK
Patch pushed to master (Could also be considered as a minor bugfix & pushed to 3.8)