Bug 8627 - Fixing pipe values in MARC21 controlfield 008 of authorities
Summary: Fixing pipe values in MARC21 controlfield 008 of authorities
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 08:45 UTC by Marcel de Rooy
Modified: 2013-05-23 06:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (3.76 KB, patch)
2012-08-13 08:48 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Followup for replacing tabs (4.27 KB, patch)
2012-08-13 09:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[SIGNED-OFF] 8627 Fixing pipe values in controlfield 008 authorities (3.79 KB, patch)
2012-08-16 12:16 UTC, Julian Maurice
Details | Diff | Splinter Review
[SIGNED-OFF] 8627 Followup for removing tabs (4.30 KB, patch)
2012-08-16 12:17 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2012-08-13 08:45:10 UTC
Within field 008 pipe values (i.e. character | ) were not passed correctly in the plugin script value_builder/marc21_field_008_authorities.pl to the template, resulting in replacement of these character positions.

Attached patch handles them correctly.
Test this in Add/Edit authorities (staff) by:
1 Without patch: Put | at the last position of 008 manually (overwrite last character). Click plugin (tag editor). Look at position 039 and click OK. You should have lost the pipe character.
2 With patch. Again put | at the end (overwrite last character). Goto tag editor and look at pos 39. Click OK. You should still have a pipe char.
3 Sign off.
Comment 1 Marcel de Rooy 2012-08-13 08:48:43 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2012-08-13 09:29:55 UTC Comment hidden (obsolete)
Comment 3 Julian Maurice 2012-08-16 12:16:58 UTC
Created attachment 11637 [details] [review]
[SIGNED-OFF] 8627 Fixing pipe values in controlfield 008 authorities

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 4 Julian Maurice 2012-08-16 12:17:07 UTC
Created attachment 11638 [details] [review]
[SIGNED-OFF] 8627 Followup for removing tabs

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 5 Julian Maurice 2012-08-16 12:19:36 UTC
Works as expected.
Comment 6 Mason James 2012-09-16 12:31:10 UTC
> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

patch looks good, passing QA…

$ koha-qa.pl 

testing 1 commit(s) (applied to commit a64c811)
 * 6dee396 8627 Followup for removing tabs
      cataloguing/value_builder/marc21_field_008_authorities.pl

* cataloguing/value_builder/marc21_field_008_authorities.pl                OK
Comment 7 Paul Poulain 2012-09-18 10:30:21 UTC
Patch pushed to master

(Could also be considered as a minor bugfix & pushed to 3.8)