Each time we add a new jQueryUI module (dialog, button, etc) or simply upgrade jQueryUI, the library files will have to be rebuilt on the jQueryUI site and updated js and CSS files committed to Koha. Currently the jQueryUI "core" CSS file (koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.css) contains customizations. These should be moved to staff-global.css so that these customizations are not lost on each upgrade.
Created attachment 11625 [details] [review] Proposed fix for the staff client Bug 8644 [staff client] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the staff client. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in Koha to confirm continued functinality: tabs, autocomplete, and datepickers.
Created attachment 11626 [details] [review] Proposed fix for the OPAC Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the OPAC. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in the OPAC to confirm continued functinality: tabs and datepickers.
Created attachment 11715 [details] [review] Bug 8644 [staff client] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the staff client. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in Koha to confirm continued functinality: tabs, autocomplete, and datepickers. Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the OPAC. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in the OPAC to confirm continued functinality: tabs and datepickers. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 11986 [details] [review] Bug 8644 [staff client] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the staff client. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in Koha to confirm continued functinality: tabs, autocomplete, datepickers, and slider (in specify due date popup).
Created attachment 12005 [details] [review] Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the OPAC. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in the OPAC to confirm continued functinality: tabs and datepickers.
Created attachment 12040 [details] [review] Bug 8644 [staff client] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the staff client. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in Koha to confirm continued functinality: tabs, autocomplete, datepickers, and slider (in specify due date popup). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 12041 [details] [review] Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the OPAC. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in the OPAC to confirm continued functinality: tabs and datepickers. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I checked out all the different jQuery widgets I could find. Everything looks good to me.
(In reply to comment #8) > I checked out all the different jQuery widgets I could find. Everything > looks good to me. looks good to me too, nice patch Owen passing QA... mason@xen1:~/g/head$ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit c8ef17e) * 5f72a63 Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations koha-tmpl/opac-tmpl/prog/en/css/opac.css koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery-ui.css koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery-ui.js * ccf406f Bug 8644 [staff client] jQueryUI CSS file should not contain customizations koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.css koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK - t/00-valid-xml.t tests... OK
Patch pushed to master, could not find anything wrong (except, maybe the fact that staff-global.css is now 2459 lines long, and would take a lot of benefit from being cleaned. But that's another topic ;-)