8648 – searchResults uses SQL query rather than GetMarcFromKohaField

Bug 8648 - searchResults uses SQL query rather than GetMarcFromKohaField

Summary: searchResults uses SQL query rather than GetMarcFromKohaField

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	3.8
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Jared Camins-Esakov
QA Contact:	Jonathan Druart

URL:
Keywords:

Depends on:
Blocks:	8649
	Show dependency tree / graph

Reported:	2012-08-15 16:34 UTC by Jared Camins-Esakov
Modified:	2013-12-05 20:01 UTC (History)
CC List:	4 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8648: searchResults uses SQL query rather than GetMarcFromKohaField (1.33 KB, patch) 2012-08-15 19:49 UTC, Jared Camins-Esakov	Details \| Diff \| Splinter Review
[SIGNED-OFF] Bug 8648: searchResults uses SQL query rather than GetMarcFromKohaField (1.35 KB, patch) 2012-08-16 09:48 UTC, Julian Maurice	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jared Camins-Esakov 2012-08-15 16:34:27 UTC

Around line 1470-something:

    my $sth =
      $dbh->prepare(
"SELECT tagfield FROM marc_subfield_structure WHERE kohafield LIKE 'items.itemnumber'"
      );
    $sth->execute;

Comment 1 Jared Camins-Esakov 2012-08-15 19:49:36 UTC Comment hidden (obsolete)

Created attachment 11629 [details] [review]
Bug 8648: searchResults uses SQL query rather than GetMarcFromKohaField

Around line 1470-something:

    my $sth =
    $dbh->prepare(
            "SELECT tagfield FROM marc_subfield_structure WHERE kohafield LIKE
            'items.itemnumber'"
            );
    $sth->execute;

This patch replaces that with a call to GetMarcFromKohaField.

To test:
1) Apply patch.
2) Do a search that returns both available and unavailable items.
   You'll know if the patch isn't working.

Comment 2 Julian Maurice 2012-08-16 09:48:24 UTC

Created attachment 11635 [details] [review]
[SIGNED-OFF] Bug 8648: searchResults uses SQL query rather than GetMarcFromKohaField

Simple change.
Does not break anything.
Save 1 query to database because result of GetMarcFromKohaField is cached.
Signed off.

Comment 3 Jonathan Druart 2012-08-16 12:24:12 UTC

QA Comment:

use the routine GetMarcFromKohaField instead of execute an sql query.

Marked as Passed QA

Comment 4 Chris Cormack 2012-08-29 21:48:45 UTC

Pushed to 3.8.x, will be in 3.8.5