It seems that you can't use display:none for <options> in IE. Patch to follow.
Created attachment 11714 [details] [review] proposed patch
Just a note that this was based on 3.8.2. Let me know if it doesn't appy in master.
The patch appears to have applied fine, but the "show all" checkbox isn't doing anything in Firefox or Internet Explorer 9. After checking it I see the same options as before.
Are you sure you have an inactive budget with funds ? Do you have any javascript errors or anything ? I tested successfully in ie8, firefox, chrome, chromium and opera. The way we use funds is we create a copy every year for new budgets. The problem is that we now have 50 funds that are in triple because we have the 10-11, 11-12 and 12-13 version of the fund with the same name. That why this problem is really critical for us.
I just tested again with the same results. I know I have an inactive budget with funds because before applying the patch I can see the effect of the "show all" checkbox: some funds are hidden and shown when changing the checkbox. I don't see any JS errors in Firebug. Results are the same in Firefox 14, Chrome 21, Opera 12, and IE 9, all on Windows 7: Only active funds are shown, and checking the box to show all has no effect.
Created attachment 11730 [details] [review] new better patch I still have no idea why it doesn't work for you. Maybe master has different code... I tested this in 3.8.3 after all. Here is a new patch that has better code because it keeps the inactive in their original position by keeping a copy of all the options before removing the inactives.
This patch works for me if I change line 138: if ($(this).attr('checked') === true) { to: if ($(this).attr('checked')) { ...which makes sense because, at least according to Firebug, the checked attribute = "checked" when the checkbox is checked. Works in FF, Chrome, Opera, and IE9 on Windows.
By the way, this could very well be a difference between jQuery 1.3.2 (in 3.8.x) and jQuery 1.7.2 in master. I don't remember off the top of my head. If the above revision works in 3.8.x then we should be fine.
Created attachment 11752 [details] [review] fixed patch new patch that tests if checkbox is checked in a way that should works in all jquery versions and is cleaner
Created attachment 11753 [details] [review] [SIGNED-OFF] Bug 8659 Remove and readd the inactive funds in javascript to make it work in all browsers Signed-off-by: Owen Leonard <oleonard@myacpl.org>
*** Bug 8669 has been marked as a duplicate of this bug. ***
QA Comments: No regression found with FF, so I marked it as Passed QA.
Patch pushed to master
Pushed to 3.8.x, will be in 3.8.6