Bug 8664 - Add floating toolbar with save button to system preferences editor
Summary: Add floating toolbar with save button to system preferences editor
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: 3.12
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
: 3988 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-21 20:29 UTC by Owen Leonard
Modified: 2013-05-23 06:24 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 8664 - Add floating toolbar with save button to system preferences editor (3.09 KB, patch)
2012-10-25 18:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8664 - Add floating toolbar with save button to system preferences editor (3.12 KB, patch)
2012-10-25 18:29 UTC, Mirko Tietgen
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-08-21 20:29:21 UTC
I propose duplicating the system preferences "save" button in a toolbar at the top of the system preferences page which will "stick" to the top of the page as you scroll down, just as the save button on addbiblio.pl does. This would make it easy to save your changes without scrolling all the way to the bottom of the screen.

The toolbar would not appear when the page displays search results since in that situation multiple save buttons might appear on the page.
Comment 1 Owen Leonard 2012-10-25 18:14:20 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2012-10-25 18:29:52 UTC
Created attachment 13060 [details] [review]
Bug 8664 - Add floating toolbar with save button to system preferences editor

This patch adds a copy of the "save" button in a toolbar at
the top of the system preferences editor. The toolbar becomes
fixed at the top of the page when you scroll down, exactly like
the toolbar on addbiblio.pl.

Because multiple save buttons might appear when the system prefs
page displays search results, the toolbar does not appear in
this case.

To test, open the system preferences editor and change a setting.
Try saving both with the button in the toolbar and the button at
the top of the page. Test scrolling to confirm that the toolbar
"sticks" to the top of the page when you scroll down.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Comment 3 Martin Renvoize (ashimema) 2012-11-01 20:06:17 UTC
*** Bug 3988 has been marked as a duplicate of this bug. ***
Comment 4 Jonathan Druart 2012-11-19 13:48:02 UTC
QA Comments:

Works as expected.

Just one remark about indentation, I am not a big fan of this kind of indendation:
+    [% UNLESS ( searchfield ) %]$(document).ready(function(){
+            $('#toolbar').fixFloat();
+        });[% END %]

It is not blocker and we don't have enough guidelines on the template files structure.

So marked as Passed QA.
Comment 5 Jared Camins-Esakov 2012-11-23 17:20:59 UTC
This patch has been pushed to master.