When looking at items in the staff client that were received via acquisitions there is a number in that field. That number is the ID for the vendor, but isn't helpful to most librarians since they don't assign that vendor ID. Could we show the name of the vendor instead? I'm not asking to change what's stored in the DB - the ID is best in this case for reporting, but just to change the display to the vendor name that matches that ID - kind of like we do with branches and item types and collection codes - etc. We don't show those codes, but the names instead.
Nicole can you please add a screenshot?
Created attachment 12105 [details] source of acquisition in item form If you look at the item info on the Items tab instead you do see the name, but the vendor ID is all that shows in the edit items screen.
This works for me in current master with a newly-received item. Nicole, can you re-test?
I just received something and see the vendor ID in the 'source of acquisition' like my screenshot ... not the name. Nicole
Can anyone reproduce this error in current master?
I think the screenshot shows the table above the edit item form. I just checked there and the table still shows the number. But it also shows unformatted dates and has other display issues that are not in line with the rest of Koha. Also, the source of acquisition field is used for an id if you use acq, but also used in other ways by libraries not using acq (free text or AV value controlled).
I am facing the same issue in my KOHA Setup. Its showing vendor id in Source of Acquisition while you go to Edit Items. This seems to be some Template data related issue. Is anyone find Solution for the same???
(In reply to Keshav Gupta from comment #7) > This seems to be some Template data related issue. Is anyone find Solution > for the same??? This bug report confirms that the problem exists, and the lack of a patch on this bug report indicates that there isn't a solution yet.
Created attachment 107821 [details] [review] Bug 8676: Display vendor's name when cataloguing items If items.booksellerid is mapped to a MARC field (952$e, Source of acquisition) then we could display a dropdown list with the list of vendors when items are edited. *However* we could have a weird display if it does not match the vendor from which the items have been effectively ordered within Koha. You could then see "Vendor X" in the cataloguing items view (additem.pl), but "Vendor Y" on the item list (moredetail.pl) Is this patch relevant? Test plan: Order and receive an item Edit the item and note the new dropdown list for "Source of acquisition" Note that the items table has replaced the value with the name of the vendor's name as well
Patch submitted for discussion, I am not sure it makes sense.
Created attachment 108636 [details] [review] Bug 8675: Display vendor's name when cataloguing items If items.booksellerid is mapped to a MARC field (952$e, Source of acquisition) then we could display a dropdown list with the list of vendors when items are edited. *However* we could have a weird display if it does not match the vendor from which the items have been effectively ordered within Koha. You could then see "Vendor X" in the cataloguing items view (additem.pl), but "Vendor Y" on the item list (moredetail.pl) Is this patch relevant? Test plan: Order and receive an item Edit the item and note the new dropdown list for "Source of acquisition" Note that the items table has replaced the value with the name of the vendor's name as well Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Current status: Signoff
This appears to break the result list: Error trace Can't use string ("") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Biblio.pm line 1366 I also have another issue: items.booksellerid is not a numerical field in items, but a text one. I know a lot of libraries not using the acq module use the field to enter the vendor name (not an id, but as text) there. I couldn't check what would happen in this case, but I guess it could be a problem for this use case.
Created attachment 109219 [details] [review] Bug 8676: Don't assume marc strucure is passed
I fixed the 500 to let you test.
Hi Jonathan, I think this could be really nice for libraries just starting out with Koha, but could be an issue for libraries that already have a lot of data in $e (existing vendor ids, non-existing vendor ids and actual vendor names). Which means it probably should be an optional feature. We run into problems here when: - Libraries have entered the vendor's name in $e (think of libraries not using the acq module) - Libraries have values in $e that cannot be resolved as a vendor, which could lead to a data loss issue. Could we somehow allow to display the data directly in the input field, if it cannot be resolved to a value from the pull down? Maybe we could split display in the items table (display vendor name when it can be resolved, otherwise display $e) and the form?
+1 this is still relevant
+1 for me, in our system I'm probably the only current staff member who would know a vendor #, so having the name would be very helpful for other staff!
I think this is still really important, but the patches no longer apply as is. As for fallbacks mentioned by Katrin, looking at the code it looks like it does just fallback to the value whenever a vendor record isn't found.. is that not enough?
It's been a long time - maybe I was worried that the field might be locked for manual input if the value is not linked to a vendor?
I won't have time to work on this in a near future.