Bug 8678 - XSLT stylesheets output XML, but HTML is needed
Summary: XSLT stylesheets output XML, but HTML is needed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low major (vote)
Assignee: Jared Camins-Esakov
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 16:21 UTC by Jared Camins-Esakov
Modified: 2013-12-05 20:01 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8678: XSLT stylesheets output XML, but HTML is needed (10.10 KB, patch)
2012-08-23 16:29 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 8678: XSLT stylesheets output XML, but HTML is needed (10.16 KB, patch)
2012-08-23 18:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2012-08-23 16:21:54 UTC
Because we are embedding the results of XSLT stylesheets in HTML, we need to output HTML instead of XML. Outputting XML results in non-standard-compliant (or at least non-Firefox-compliant) markup.
Comment 1 Jared Camins-Esakov 2012-08-23 16:29:03 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2012-08-23 18:11:45 UTC
Created attachment 11802 [details] [review]
Bug 8678: XSLT stylesheets output XML, but HTML is needed

Because we are embedding the results of XSLT stylesheets in HTML, we
need to output HTML instead of XML. Outputting XML results in
non-standard-compliant (or at least non-Firefox-compliant) markup.

To test:
View a variety of XSLT-rendered pages on the OPAC and intranet, and
confirm that all look as expected.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 3 Tomás Cohen Arazi 2012-08-23 18:12:58 UTC
Tested both on master and 3.8.x.
Comment 4 Fridolin Somers 2012-08-30 08:38:05 UTC
Perfect, I was waiting for this patch.
XML output caused Bug 8513 :
  With XML output, an empty tag will appear has : <a/>.
  With HTML output, it will appear has : <a></a>.
For web browser the first form for an anchor is not allowed.

In most case, HTML output is more friendly with XSLT result and causes less crash.

I tested a bit in UNIMARC, all ok.
Comment 5 Jonathan Druart 2012-09-05 13:00:47 UTC
Seems good for me too.
Marked as Passed QA.
Comment 6 Paul Poulain 2012-09-07 16:35:58 UTC
Patch pushed to master
Comment 7 Chris Cormack 2012-09-08 09:16:30 UTC
Pushed to 3.8.x, will be in 3.8.5
Comment 8 Jared Camins-Esakov 2012-12-03 13:06:55 UTC
Works on master.