Bug 8711 - alternating colors messed up on reports
Summary: alternating colors messed up on reports
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-31 19:52 UTC by Nicole C. Engard
Modified: 2013-05-23 06:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
reports sorted by name (34.42 KB, image/png)
2012-08-31 19:52 UTC, Nicole C. Engard
Details
Bug 8711 - alternating colors messed up on reports (1.45 KB, patch)
2012-09-06 19:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8711 - alternating colors messed up on reports (1.46 KB, patch)
2012-09-06 22:11 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-08-31 19:52:47 UTC
Created attachment 11933 [details]
reports sorted by name

If reports are sorted by a field other than the ID the alternating colors are not actually alternating. See attached.
Comment 1 Owen Leonard 2012-09-06 19:23:28 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-09-06 22:11:04 UTC
Created attachment 12030 [details] [review]
Bug 8711 - alternating colors messed up on reports

Patch adds the "zebra-striping" option to the
table sorter initialization and changes the row
color CSS to match the tablesorter's to prevent
conflicts.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 3 Paul Poulain 2012-10-02 16:06:41 UTC
QA comment:
 * 0 side effect risk, template & reports only
 * passes koha-qa.pl

passed QA
Comment 4 Paul Poulain 2012-10-02 16:08:56 UTC
Patch pushed to master

Minor bugfix, but I think it's more a bugfix than an ENH
Comment 5 Chris Cormack 2012-10-03 19:24:25 UTC
Yep, it is a bug fix, pushed to 3.8.x will be in 3.8.6