The detail.pl file is pushing "notes" when it should be pushing "internalnotes".
Created attachment 11949 [details] [review] Bug 8717 - Wrong subscription notes are showing in catalogue detail view of serials in staff client
Hi David, The header column is "Public notes" then I suppose we want to display the public note rather than the internalnotes.
Hi Jonathan: I'm not sure where you are looking, but I don't see a header column on the page to which I'm referring. I'll attach a screenshot. (In reply to comment #2) > Hi David, > The header column is "Public notes" then I suppose we want to display the > public note rather than the internalnotes.
Created attachment 11994 [details] Screenshot of "subscription notes" This is the patched version. Ordinarily, it would show "subscription public note" .
(In reply to comment #4) > Created attachment 11994 [details] > Screenshot of "subscription notes" > > This is the patched version. Ordinarily, it would show "subscription public > note" . Yes, sorry, I didn't test at the right place :)
Created attachment 12001 [details] [review] Bug 8717 - Wrong subscription notes are showing in catalogue detail view of serials in staff client Changes the subscription note from the opac "notes" to the proper staff client "internalnotes" field. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 2a60d49) * 1685fe5 Bug 8717 - Wrong subscription notes are showing in catalogue deta catalogue/detail.pl * catalogue/detail.pl OK
Patch pushed to master
Pushed to 3.8.x, will be in 3.8.5