Bug 8724 - Upgrade from NoZebra installs is broken
Summary: Upgrade from NoZebra installs is broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks: 7440
  Show dependency tree / graph
 
Reported: 2012-09-04 17:33 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2013-12-05 20:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8724 - Upgrade from NoZebra installs is broken (5.39 KB, patch)
2012-09-04 18:07 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 8724 - Upgrade from NoZebra installs is broken (5.44 KB, patch)
2012-09-07 13:44 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 8724 - Upgrade from NoZebra installs is broken (5.40 KB, patch)
2012-10-22 07:10 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2012-09-04 17:33:14 UTC 
If the NoZebra syspref is set Koha gets busted after an upgrade, which doesnt warn the user about that.
Comment 1 Tomás Cohen Arazi (tcohen) 2012-09-04 18:07:55 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall (khall) 2012-09-07 13:44:11 UTC Comment hidden (obsolete)
Comment 3 Jared Camins-Esakov 2012-10-06 04:15:02 UTC 
Upgrading severity.
Comment 4 Jonathan Druart 2012-10-19 14:53:52 UTC 
Hi Tomás
Why don't you remove completely the sysprefs in the DB?
Comment 5 Tomás Cohen Arazi (tcohen) 2012-10-19 15:40:58 UTC 
(In reply to comment #4)
> Hi Tomás
> Why don't you remove completely the sysprefs in the DB?

I was told on IRC that we don't usually delete them. Anyway, there's another bug for removing every NoZebra vestiges, I plan to contribute there.
Comment 6 Jared Camins-Esakov 2012-10-19 15:44:26 UTC 
(In reply to comment #4)
> Hi Tomás
> Why don't you remove completely the sysprefs in the DB?

I encouraged Tomás not to remove the sysprefs yet, since there is still code that might be checking that syspref.
Comment 7 Jonathan Druart 2012-10-22 07:10:46 UTC 
Created attachment 12994 [details] [review]
Bug 8724 - Upgrade from NoZebra installs is broken

Properly set the relevant NoZebra and QueryRemoveStopwords sysprefs to 0 to fix issues on upgrades.
Also removes the sysprefs from preferences/searching.pref

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Jonathan Druart 2012-10-22 07:11:46 UTC 
(In reply to comment #6)
> I encouraged Tomás not to remove the sysprefs yet, since there is still code
> that might be checking that syspref.

So this patch passes QA.
Comment 9 Paul Poulain 2012-10-22 13:01:52 UTC 
Patch pushed to master (& bug reassigned to patch author, in case of a follow-up needed)