Created attachment 11996 [details] PowerPoint Presentation of mockups A proposal to enhance the detail page of a book by adding a section titled "Book reviews by critics" similar to the "Amazon reviews" section. This section would display 5 critic reviews from idreambooks.com as per the guidelines in iDreamBooks' API (idreambooks.com/api). For example, for the book MoonWalking with Einsten, the editorial review snippets from sources like The Guardian, NYTimes, WashingtonPost, etc. would be shown. See example of API output for the book here: http://idreambooks.com/newbooks/api.xml?q=moonwalking+with+einstein+foer&key=example_key In addition to the review snippets, the overall rating of the book would get displayed on the detail page of a book to help users gauge the rating of the book in an instant. The rating on it's own or the entire "Readometer" or both can be displayed. For example, for the book MoonWalking with Einstein, it's rating of 80% would be displayed under the title of the book. Alternatively, the "Readometer" could also be displayed. Please see attached powerpoint presentation for images that give more detail. We (iDreamBooks) are willing to provide development assistance to implement these enhancements.
Created attachment 12015 [details] Slide one: New tab
Created attachment 12016 [details] Slide 2: Snippets of critics' reviews
Created attachment 12017 [details] Slide 3: Critics' rating
Created attachment 12018 [details] Slide 4: Readometer
We have added a way to retrieve the "Readometer" based on ISBN number. See http://www.idreambooks.com/remotereadometer/9780143120537.html for example. Also, we would need help from the community for implementation as we are a bit thin on resources.
Created attachment 12493 [details] [review] Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate.
Created attachment 12501 [details] [review] Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme.
Created attachment 12583 [details] [review] [SIGNED-OFF] Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Followed the test plan, everything looks good!
Created attachment 12587 [details] [review] [SIGNED-OFF] Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass.
Created attachment 12588 [details] [review] [SIGNED-OFF] Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
tagging this for inclusion in 3.12 release...
(In reply to comment #12) > tagging this for inclusion in 3.12 release... Is there anyway we can get this into the next release of 3.10? Like 3.10.1 (assuming the first one is 3.10.0)? The development has been completed...and looks like tests are passing...?
Here's how Koha releases work http://koha-community.org/about/release-schedule/ New features only go into a .0 release, and this feature has missed the feature freeze for 3.10.0, so the next feature release is 3.12.0. It can obviously get pushed up into git, but it won't be in an official release before then. (Speaking as the release maintainer (unless someone else volunteers that is) for 3.10.x)
QA Comment: I cannot test this feature. Where is the class 'isbn' used to set the js variable isbn ? var isbn = $(".isbn:last").text().split(" ")[1]; I don't find any occurrence of this class in the opac detail page. Question: What is the key (key=8bf66516232d1b72f3e47df939653e1e) used in the url to idreambooks.com ? Is it a good idea to hard code it in the template ? These patchs have to be rebased, I switch the status to "does not apply".
Created attachment 14345 [details] [review] Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased to latest master 2012-12-31
(In reply to comment #15) No answer ? > I cannot test this feature. > Where is the class 'isbn' used to set the js variable isbn ? > var isbn = $(".isbn:last").text().split(" ")[1]; > I don't find any occurrence of this class in the opac detail page. Finally I understand, the class is added by the webservice. > Question: What is the key (key=8bf66516232d1b72f3e47df939653e1e) used in the > url to idreambooks.com ? Is it a good idea to hard code it in the template ? But I would like to have an answer for these questions before to pass qa this patch.
(In reply to comment #17) > (In reply to comment #15) > > No answer ? > > > I cannot test this feature. > > Where is the class 'isbn' used to set the js variable isbn ? > > var isbn = $(".isbn:last").text().split(" ")[1]; > > I don't find any occurrence of this class in the opac detail page. > > Finally I understand, the class is added by the webservice. > > > Question: What is the key (key=8bf66516232d1b72f3e47df939653e1e) used in the > > url to idreambooks.com ? Is it a good idea to hard code it in the template ? > > But I would like to have an answer for these questions before to pass qa > this patch. Sorry, I didn't see the question. The key was assigned by idreambooks.com for Koha.
I got the same problem as last time. The detail page does not displayed the readometer, the critic rating and the reviews. The isbn variable is always undefined in the following test: [% IF ( IDreamBooksReviews || IDreamBooksReadometer ) %] var isbn = $(".isbn:last").text().split(" ")[1]; // I pass here if (isbn) { // I never pass here There is no isbn class in my generated html! What I missed?
Created attachment 14980 [details] [review] Bug 8733 follow-up: restore isbn class in details page For some reason the isbn CSS class was missing from the details page, presumably due to a bad merge. This one-line commit re-adds it so that the critics reviews will show up.
The isbn class was already in the XSLT view, but I rebased out the added class from the normal view. I did a follow-up to re-add the line.
I tried with an isbn-13 (978-*) and the ws does not return any result. But if I delete the dash, the ws returns the good one.
Created attachment 15001 [details] [review] Bug 8733: Follow-up The isbn sent to idream contains dash
Jared, do you think this patch is relevant?
Created attachment 15012 [details] [review] Bug 8733 follow-up: restore isbn class in details page For some reason the isbn CSS class was missing from the details page, presumably due to a bad merge. This one-line commit re-adds it so that the critics reviews will show up. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 15013 [details] [review] Bug 8733: Follow-up The isbn sent to idream contains dash Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(In reply to comment #24) > Jared, do you think this patch is relevant? Yes, I think it was a very good idea. I signed off on your follow-up.
QA comments: Everything works to me now. The critic rating area is displayed on the bottom of the details contrary to what the snapshot points out (not blocker). I didn't find any regression or any problem with the proposed code. So I mark as passed QA these patchs.
Created attachment 15024 [details] [review] Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased to latest master 2012-12-31 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 15025 [details] [review] Bug 8733 follow-up: restore isbn class in details page For some reason the isbn CSS class was missing from the details page, presumably due to a bad merge. This one-line commit re-adds it so that the critics reviews will show up. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 15026 [details] [review] Bug 8733: Follow-up The isbn sent to idream contains dash Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
I was going to document this, I have the preferences, but don't see the content when i turn them on ... is there maybe an updatedatabase problem here?
The problem is in the limited content. I have added a warning to the manual - the feature itself does in fact work though :)