At the moment, you have to step through vendors one at a time. It should be possible to see all overdues at once, if chosen explicitly because the list may be large.
Created attachment 12068 [details] [review] enh bug 8740 Serials Claims should be exportable all at once
Created attachment 12155 [details] [review] [SIGNED OFF]enh bug 8740 Serials Claims should be exportable all at once Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
QA comments: This patch allows $supplierid to be a string or an integer. We have some warnings in logs: Argument "all" isn't numeric in numeric eq (==) Maybe a better option would be to set the "all suppliers" value with -1. Marked as Failed QA
Created attachment 15788 [details] [review] enh bug 8740 Serials Claims should be exportable all at once Test plan: 1. Visit Serials: Claims and look at the vendor list drop-down 2. select All 3. click OK 4. export them all
Created attachment 15789 [details] [review] enh bug 8740 Serials Claims should be exportable all at once Test plan: 1. Visit Serials: Claims and look at the vendor list drop-down 2. select All 3. click OK 4. export them all
I've rebased this and changed a == to an eq to avoid the warnings. I have not set the "all suppliers" value with -1 because I dislike magic numbers and it is possible (but unlikely unless you mess with the database directly) to have a vendor with id -1 which would become unselectable alone. I ask for reviews and maybe new signoffs, please.
Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr>
Created attachment 16491 [details] [review] enh bug 8740 Serials Claims should be exportable all at once Test plan: 1. Visit Serials: Claims and look at the vendor list drop-down 2. select All 3. click OK 4. export them all Signed-off-by: Frederic Durand <frederic.durand@unilim.fr>
QA comment: Sorry MJ but the warning still occur when the string is not initialized: Use of uninitialized value $supplierid in string eq at /home/koha/src/serials/claims.pl line 71 Marked as Failed QA.
Still valid?