Test ---- 1) Clone fresh Ubuntu install 2) sudo apt-get install git git-email 3) git clone git://git.koha-community.org/koha.git kohaclone 4) cd kohaclone 5) sudo apt-get install dselect 6) sudo dpkg --set-selections < install_misc/ubuntu.packages 7) sudo dselect 8) I,C,R,Q 9) ./koha_perl_deps.pl -m -u Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- Template::Plugin::HtmlToText 0 * 0.03 Yes Test::Strict 0 * 0.14 No -------------------------------------------------------------------------------------------- 10) grep template install_misc/ubuntu.packages 11) The file (libtemplate-plugin-htmltotext-perl) is not listed 12) apply patch 13) repeat 6-9 14) should be a blank list.
After looking at the 3.8.x repo, I realized this was only a problem with the 3.8.4 release. It should be corrected in the 3.8.5 release.
DOH! wrong git branch. Bug exists in master and 3.8.x only.
Created attachment 12328 [details] [review] Added missing libtemplate-plugin-htmltotext to ubuntu.*.packages files Adds missing required library. Keeps the installation steps simpler. :) This is for master. Does not apply against 3.8.x, patch to follow.
Created attachment 12329 [details] [review] Added missing libtemplate-plugin-htmltotext to ubuntu.*.packages files (3.8.x) Added missing libtemplate-plugin-htmltotext-perl library into the ubuntu.*.packages files. This is for 3.8.x.
Created attachment 13066 [details] [review] Bug 8749 - Missing Ubuntu library files in ubuntu.*.packages Added: libtemplate-plugin-htmltotext-perl install into the four files, as this is available in the debian.koha-community.org repository. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 13067 [details] [review] Bug 8749 - Missing Ubuntu library files in ubuntu.*.packages (3.8.x) Added libtemplate-plugin-htmltotext-perl install into the ubuntu.*.packages files. The missing library exists in the debian.koha-community.org repository. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
QA comment: both patches are almost the same, and I don't understand if I should apply both of them (sounds illogical), if one should be obsoleted, if one is for 3.8 and the other for master explanation welcomes ;-)
The differences are which file are patched. Master and 3.8.x didn't apply cleanly last I tried, because Master had more dependencies. I think that was the difference. Open the two in two separate tabs, switch back and forth. The third section shows indentation differences and file differences. tcohen forgot to match which one was 3.8.x, but it should be obvious when the patch fails to apply. Compare it to the obsoleted ones to know for sure. :)
(In reply to comment #8) > The differences are which file are patched. Master and 3.8.x didn't apply > cleanly last I tried, because Master had more dependencies. I think that was > the difference. Open the two in two separate tabs, switch back and forth. > The third section shows indentation differences and file differences. tcohen > forgot to match which one was 3.8.x, but it should be obvious when the patch > fails to apply. Compare it to the obsoleted ones to know for sure. :) perfect, thanks QA comment: tiny patch, add needed dependencies in Ubuntu packages, passed QA
Patch pushed to master
Pushed to 3.8.x will be in 3.8.7