Bug 8758 - Code seems useless in circ/returns.pl
Summary: Code seems useless in circ/returns.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-11 13:05 UTC by Jonathan Druart
Modified: 2013-05-23 06:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8758: Remove useless code in circ/returns.pl (4.61 KB, patch)
2012-09-11 13:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SINGED-OFF] Bug 8758: Remove useless code in circ/returns.pl (5.08 KB, patch)
2012-09-14 20:37 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2012-09-11 13:05:53 UTC

    
Comment 1 Jonathan Druart 2012-09-11 13:07:38 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2012-09-11 13:08:41 UTC
Could someone confirm this code is unused ?
Comment 3 Owen Leonard 2012-09-14 20:37:39 UTC
Created attachment 12255 [details] [review]
[SINGED-OFF] Bug 8758: Remove useless code in circ/returns.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Before applying the patch I removed the [% IF %] from
around the markup which is removed by this patch. A table
of title and patron information appeared which I don't
remember ever seeing before. This tells me it's really
unused.

After applying the patch I performed some check-ins on both
checked out items and items which were on hold. All operations
completed normally.
Comment 4 Paul Poulain 2012-10-03 15:50:39 UTC
QA comment:
 * patch with a very big side effect, if we missed a case where this information is displayed. That's why I won't push it for 3.10, it fit the rule of "Feature Freeze"
 * koha-qa.pl OK
 * remove code only

passed QA. Will be pushed after 3.10 release (and not pushed by me ;-) )
Comment 5 Jared Camins-Esakov 2012-11-23 16:54:21 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2012-11-26 01:04:24 UTC
Pushed to 3.10.x will be in 3.10.1