With the system preference "IndependantBranches" set to On, only a superlibrarian can make transfers. The page is still displayed for others librarians with circulation rights, but they can only chose their own library as a destination, making the page useless for them. The link to this page could be hidden in such cases.
Created attachment 12298 [details] [review] proposed patch TEST PLAN : It's about testing the display of the "Transfer" link on "circulation-home.pl". The link needs to appear if IndependantBranches is off or if the user is a superlibrarian. 1) IndependantBranches = Off, user is superlibrarian : link appears 2) IndependantBranches = Off, user is not superlibrarian : link appears 3) IndependantBranches = On, user is superlibrarian : link appears 4) IndependantBranches = On, user is not superlibrarian : link does not appear
Thanks for the test plan! I followed steps #1-4, and everything behaves as you described. I am signing off.
Created attachment 13321 [details] [review] [Signed off] Bug 8781: hiding of transfer page when it's useless The transfer page is only useful when the system preference "IndependantBranches" is Off of when the user is a superlibrarian. Otherwise it can be hidden. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Created attachment 13820 [details] [review] [SIGNED-OFF] Bug 8781: hiding of transfer page when it's useless The transfer page is only useful when the system preference "IndependantBranches" is Off of when the user is a superlibrarian. Otherwise it can be hidden. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. TEST PLAN : It's about testing the display of the "Transfer" link on "circulation-home.pl". The link needs to appear if IndependantBranches is off or if the user is a superlibrarian. 1) IndependantBranches = Off, user is superlibrarian : link appears 2) IndependantBranches = Off, user is not superlibrarian : link appears 3) IndependantBranches = On, user is superlibrarian : link appears 4) IndependantBranches = On, user is not superlibrarian : link does not appear
Passed QA. Note: The page is still accessible (and not useful) when indybranches is ON and user is not superlibrarian. But this is an improvement.
This patch has been pushed to master.
Bug fix really, pushed to 3.10.x and 3.8.x, will be in 3.10.1 and 3.8.8