When I put a number in "Enter starting card number" I am expecting it to start printing cards in that position the way it does in the label creator. However it always starts in the first position. I have tested and confirmed this in 3.8.4 and Master (as of this morning).
Created attachment 12485 [details] Starting labels on positions 2 and 7 (on the label sheet) It took quite a while until I figured out what happens - it is simply a misunderstanding: The label position means the position where the first label is positioned on the printout sheet (and not the index of the first label to print). Ah, and this said: It only affects PDF printing, not CSV or XML export. See screenshots of PDF printouts attached (same batch, starting at the 2nd and at the 7th position). Marc
Created attachment 12487 [details] [review] Bug 8796 - patron cards not starting on designated card Better wording for the meaning of 'Position' to prevent mistakes on behaviour.
Created attachment 12573 [details] [review] [SIGNED-OFF] Bug 8796 - patron cards not starting on designated card Better wording for the meaning of 'Position' to prevent mistakes on behaviour. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to comment #3) > Created attachment 12573 [details] [review] > [SIGNED-OFF] Bug 8796 - patron cards not starting on designated card > > Better wording for the meaning of 'Position' to prevent mistakes on > behaviour. > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> trivial patch, passing QA...
Patch pushed to master (severity lowered, it's not major !)
Pushed to 3.8.x, will be in 3.8.6
This is an issue in the 3.10.x (and probably master) branch
I reopened this last year and then veron@veron.ch closed it without comment. This is still an issue in master as of this morning. I tested it. Nicole
Sorry, I mistaked. After patch 2012-09-28 12:45 UTC was pushed for 3.8.6 (signed off by Kyle M Hall), the behavior was as expected (Better wording for the meaning of 'Position' to prevent mistakes on behaviour). It seems that meanwhile the behaviour changed. On current master, printing a batch of cards seems always to start on the first (top left) position (and not as shown in attachment 1). Should the version be set to "Current master" (instead of 3.8) ?
The bug is still existing in 3.18.4. Printing in the created .pdf starts irrespective of input in position 1 of the label sheet/template. The bug is effectively preventing the use of patron label creator. So I suggest it to be given higher priority! Moreover the documentation of the patron card creator in the manual is incomplete. In http://translate.koha-community.org/manual/3.18/en/html-desktop \ /#patroncardcreator Chapter 3.1.6.4. Batches seems to be truncated / incomplete. The text displayed in the 3.18.4 export popup is Enter starting card number and seems not to be consistent with attachment [SIGNED-OFF] Bug 8796... The user is still left without clear idea what this value means. Why not use a text similar to "Start printing in template-position" []
Comment on attachment 12573 [details] [review] [SIGNED-OFF] Bug 8796 - patron cards not starting on designated card Applying: Bug 8796 - patron cards not starting on designated card Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... No changes -- Patch already applied. Obsoleted this patch.
Created attachment 37343 [details] [review] Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form.
Created attachment 37355 [details] [review] Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected
Created attachment 37520 [details] [review] [PASSED QA] Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Please rebase so I push it.
Created attachment 37628 [details] [review] Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased to apply on master / MV
Comment on attachment 37628 [details] [review] Bug 8796 - patron cards not starting on designated card Did a mistake while rebasing. Obsoleted.
Created attachment 37629 [details] [review] Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased for current master and tested. /MV
I hope it's OK to put it back to Passed QA after rebase (1 line).
(In reply to Marc Véron from comment #19) > I hope it's OK to put it back to Passed QA after rebase (1 line). It is!
Patch pushed to master. Thanks Marc!
String changes, held for 3.18.7
Theres a conflict in patroncards/create-pdf.pdf .. please rebase on 3.18.x if you want it in 3.18.7