Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table
Summary: Staff Client: Patron search should display branch name instead of branch code...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Marc Véron
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-24 16:06 UTC by Marc Véron
Modified: 2013-12-05 20:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table (2.40 KB, patch)
2012-09-24 16:19 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table (2.42 KB, patch)
2012-09-28 13:11 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table (2.42 KB, patch)
2012-09-28 13:28 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2012-09-24 16:06:40 UTC
Result list in patron search should display branchname instead of branchcode. 

Similar reason as with Bug 8810:

The name of the branch can change and the original meaning of the branchcode could be lost (that happened to us and we need a solution asap). Since branchcode is used as database key as well it would be very difficult to change it in all the tables.

Patch follows.

Marc
Comment 1 Marc Véron 2012-09-24 16:19:20 UTC Comment hidden (obsolete)
Comment 2 Paul Poulain 2012-09-28 13:11:12 UTC
Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com>
Comment 3 Paul Poulain 2012-09-28 13:11:30 UTC Comment hidden (obsolete)
Comment 4 Paul Poulain 2012-09-28 13:28:11 UTC
Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com>
Comment 5 Paul Poulain 2012-09-28 13:28:28 UTC
Created attachment 12584 [details] [review]
Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table

Patch to display branchname instead of branch code.

Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Comment 6 Mason James 2012-10-04 01:57:45 UTC
(In reply to comment #5)
> Created attachment 12584 [details] [review]
> Bug 8812 - Staff Client: Patron search should display branch name instead of
> branch code in results table
> 
> Patch to display branchname instead of branch code.
> 
> Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>

works as expected, passing QA...

$ koha-qa.pl -c 1

testing 1 commit(s) (applied to commit 6c18204)
 * af7db2e Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table
      koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
      members/member.pl

* members/member.pl                                                        OK
* koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt                OK
Comment 7 Paul Poulain 2012-10-08 16:06:06 UTC
QA comment: the branchname information is available, so I accept this patch. But it could have been written using the Koha::Template::Plugin::Branchname template plugin.

With caching + new code structure, that will reduce global code size & be as efficient.

Would you be OK to provide an alternative patch ? (if no, I'll push this one, no problem with it. But if you can provide a better one, I won't miss that ;-) )
Comment 8 Marc Véron 2012-10-08 19:40:47 UTC
Sorry, I'm afraid I have no time at the moment to find out how to make use of Koha::Template::Plugin::Branchname template plugin.

Would appreciate to see it pushed.

Marc
Comment 9 Paul Poulain 2012-10-11 09:18:29 UTC
Patch pushed to master
Comment 10 Chris Cormack 2013-04-21 00:44:01 UTC
Released in 3.10.0