Result list in patron search should display branchname instead of branchcode. Similar reason as with Bug 8810: The name of the branch can change and the original meaning of the branchcode could be lost (that happened to us and we need a solution asap). Since branchcode is used as database key as well it would be very difficult to change it in all the tables. Patch follows. Marc
Created attachment 12479 [details] [review] Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code.
Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com>
Created attachment 12580 [details] [review] Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Created attachment 12584 [details] [review] Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
(In reply to comment #5) > Created attachment 12584 [details] [review] > Bug 8812 - Staff Client: Patron search should display branch name instead of > branch code in results table > > Patch to display branchname instead of branch code. > > Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> works as expected, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * af7db2e Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt members/member.pl * members/member.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt OK
QA comment: the branchname information is available, so I accept this patch. But it could have been written using the Koha::Template::Plugin::Branchname template plugin. With caching + new code structure, that will reduce global code size & be as efficient. Would you be OK to provide an alternative patch ? (if no, I'll push this one, no problem with it. But if you can provide a better one, I won't miss that ;-) )
Sorry, I'm afraid I have no time at the moment to find out how to make use of Koha::Template::Plugin::Branchname template plugin. Would appreciate to see it pushed. Marc
Patch pushed to master
Released in 3.10.0