Rather than show the "Order Details" heading and a "Basket empty" message it would be simpler to hide the table altogether so that the focus could move to the "Add order to basket" form.
Created attachment 12505 [details] [review] Bug 8820 - Don't show orders table if there are no orders This page removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. This patch also moves the "Show all details" checkbox under the "Orders" heading to associate it more closely with the area it affects. Other textual changes: - Correcting capitalization according to coding guidelines - Correcting terminology (basket group instead of basketgroup) - Replacing the "Order Details" heading with the more succinct "Orders"
Created attachment 12535 [details] [review] [SIGNED-OFF] Bug 8820 - Don't show orders table if there are no orders This page removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. This patch also moves the "Show all details" checkbox under the "Orders" heading to associate it more closely with the area it affects. Other textual changes: - Correcting capitalization according to coding guidelines - Correcting terminology (basket group instead of basketgroup) - Replacing the "Order Details" heading with the more succinct "Orders" Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
QA comment * template/styling only patch, no side effect risk * passes koha-qa.pl passed QA
Patch pushed to master
Doesn't apply on 3.8.x please reformat and send for 3.8.x if it is needed
Created attachment 13611 [details] [review] Bug 8820 [3.8.x] Don't show orders table if there are no orders Reworkd for 3.8.x: Patch removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. Other textual changes: - Correcting capitalization according to coding guidelines - Replacing the "Order Details" heading with the more succinct "Orders"
Created attachment 13805 [details] [review] [Signed off] Bug 8820 [3.8.x] Don't show orders table if there are no orders Reworkd for 3.8.x: Patch removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. Other textual changes: - Correcting capitalization according to coding guidelines - Replacing the "Order Details" heading with the more succinct "Orders" Signed-off-by: Melia Meggs <melia@bywatersolutions.com>
I applied this patch 3.8.7. I looked at an empty basket and see that the Order Details and Basket Empty messages are now gone. I looked at a non-empty basket and see that Order Details has been changed to just Orders. All looks good, so I'm signing off.
Created attachment 13814 [details] [review] [SIGNED-OFF] Bug 8820 [3.8.x] Don't show orders table if there are no orders Reworkd for 3.8.x: Patch removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. Other textual changes: - Correcting capitalization according to coding guidelines - Replacing the "Order Details" heading with the more succinct "Orders" Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass, template change only. To test: 1) Create a new basket - verify 'basket empty' shows up 2) Create order line - verfiy table heading is 'Order Details' 3) Close basket, check capitalization on basket group dialog Repeat with patch applied. - 'basket empty' is gone - Heading is now 'Orders' - Capitalization on basket group dialog is correct
Pushed to 3.8.x, will be in 3.8.8