Bug 8827 - YUI CSS files no longer found on Yahoo servers
Summary: YUI CSS files no longer found on Yahoo servers
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks: 8867
  Show dependency treegraph
 
Reported: 2012-09-26 12:46 UTC by Owen Leonard
Modified: 2013-12-05 20:01 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8827 - YUI CSS files no longer found on Yahoo servers (1.87 KB, patch)
2012-09-26 13:05 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED_OFF] Patch (1.95 KB, patch)
2012-09-26 13:37 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-09-26 12:46:23 UTC
If you have your yuipath preference set to retrieve YUI files from Yahoo's servers, your OPAC layout will break because the CSS files are no longer at the old location.

The short-term fix is to always retrieve YUI CSS from the local file system (as we do in the staff client). A longer-term fix is to remove the yuipath preference altogether (since it is a goal to eliminate YUI) or generalize it to include other assets like jQuery which can also be found on CDNs like Google's (see http://jquery.com/download/ for the currently available CDN links).
Comment 1 Owen Leonard 2012-09-26 13:05:30 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2012-09-26 13:37:11 UTC
Created attachment 12526 [details] [review]
[SIGNED_OFF] Patch
Comment 3 Marcel de Rooy 2012-09-26 13:37:35 UTC
Fixes broken display.
Comment 4 Marcel de Rooy 2012-09-26 13:40:30 UTC
Would it be an idea to add some text next to the pref, mentioning that css is always local and javascript comes from Yahoo, or something like that?
Comment 5 Mason James 2012-10-03 00:09:17 UTC
(In reply to comment #2)
> Created attachment 12526 [details] [review]
> [SIGNED_OFF] Patch

works as expected, passing QA...

$ koha-qa.pl -c 1

testing 1 commit(s) (applied to commit 0a35b26)
 * 47fd399 Bug 8827 - YUI CSS files no longer found on Yahoo servers
      koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc

* koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc                  OK
Comment 6 Mason James 2012-10-03 00:12:30 UTC
(In reply to comment #4)
> Would it be an idea to add some text next to the pref, mentioning that css
> is always local and javascript comes from Yahoo, or something like that?

great idea - i've added a new bug to track this

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8867
Comment 7 Mason James 2012-10-03 00:14:15 UTC
(In reply to comment #6)
> (In reply to comment #4)
> > Would it be an idea to add some text next to the pref, mentioning that css
> > is always local and javascript comes from Yahoo, or something like that?
> 
> great idea - i've added a new bug to track this
> 
> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8867

ahh, ignore this bug - i just clicked that its CSS *only*, thats local :)
Comment 8 Paul Poulain 2012-10-05 09:51:15 UTC
Patch pushed to master
Comment 9 Chris Cormack 2012-10-06 06:56:12 UTC
Patch does not apply to 3.8.x, please resubmit.
Comment 10 Owen Leonard 2012-11-21 19:14:30 UTC
(In reply to comment #9)
> Patch does not apply to 3.8.x, please resubmit.

Not applicable to 3.8.x.