Bug 8850 - Can't place hold on title with ILS-DI
Summary: Can't place hold on title with ILS-DI
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 09:57 UTC by Julian Maurice
Modified: 2013-12-05 20:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8850: Export CanBookBeReserved in C4::ILSDI::Services (865 bytes, patch)
2012-10-01 10:02 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 8850: Export CanItemBeReserved in C4::ILSDI::Services (906 bytes, patch)
2012-10-02 09:27 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 8850: Export CanBookBeReserved in C4::ILSDI::Services (932 bytes, patch)
2012-10-03 08:53 UTC, Matthias Meusburger
Details | Diff | Splinter Review
Bug 8850: Export CanItemBeReserved in C4::ILSDI::Services (968 bytes, patch)
2012-10-03 08:53 UTC, Matthias Meusburger
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2012-10-01 09:57:16 UTC
When going on this address: /cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=84238&bib_id=115570&request_location=127.0.0.1

I get a software error

Undefined subroutine &C4::ILSDI::Services::CanBookBeReserved called at /home/koha/src/C4/ILSDI/Services.pm line 606.
Comment 1 Julian Maurice 2012-10-01 10:02:01 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2012-10-01 10:04:05 UTC
To test, go to 
http://yourlibrary/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=PATRON_ID&bib_id=BIB_ID&request_location=127.0.0.1
replacing PATRON_ID with a valid borrowernumber and BIB_ID with a valid biblionumber.
Comment 3 Julian Maurice 2012-10-02 09:27:58 UTC Comment hidden (obsolete)
Comment 4 Matthias Meusburger 2012-10-03 08:53:25 UTC
Created attachment 12655 [details] [review]
Bug 8850: Export CanBookBeReserved in C4::ILSDI::Services

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Comment 5 Matthias Meusburger 2012-10-03 08:53:29 UTC
Created attachment 12656 [details] [review]
Bug 8850: Export CanItemBeReserved in C4::ILSDI::Services

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Comment 6 Matthias Meusburger 2012-10-03 08:54:35 UTC
Signed-off.
Comment 7 Mason James 2012-10-04 00:41:14 UTC
(In reply to comment #5)
> Created attachment 12656 [details] [review]
> Bug 8850: Export CanItemBeReserved in C4::ILSDI::Services
> 
> Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>

trivial patches, passing QA...

$ koha-qa.pl -c 2

testing 2 commit(s) (applied to commit 6c18204)
 * 3c1edec Bug 8850: Export CanItemBeReserved in C4::ILSDI::Services
      C4/ILSDI/Services.pm

 * 8051567 Bug 8850: Export CanBookBeReserved in C4::ILSDI::Services
      C4/ILSDI/Services.pm

* C4/ILSDI/Services.pm                                                     OK
Comment 8 Paul Poulain 2012-10-05 15:39:46 UTC
Patch pushed to master
Comment 9 Chris Cormack 2012-10-06 07:10:55 UTC
Pushed to 3.8.x will be in 3.8.6
Comment 10 Julian Maurice 2012-10-11 07:57:45 UTC
Ok in master and in 3.8.x.
Marked as RESOLVED.