Bug 8869 - Duplicate member check doesn't disable submit button on bottom.
Summary: Duplicate member check doesn't disable submit button on bottom.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 14:48 UTC by Kyle M Hall
Modified: 2013-05-23 06:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8869 - Duplicate member check doesn't disable submit button on bottom. (1.16 KB, patch)
2012-10-03 14:49 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8869 - Duplicate member check doesn't disable submit button on bottom. (1.45 KB, patch)
2012-10-04 08:18 UTC, Frédéric Demians
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2012-10-03 14:48:17 UTC
When Koha suspects a new patron is actually a duplicate of an existing patron, the new patron form is re-displayed and asked for confirmation on whether this new patron is really a duplicate or not.

The problem is, we want the librarian to click one of those buttons, but it's also possible to scroll down and use the submit button at the bottom. I have actual reports of librarians not bothering to read the message but scrolling down to the bottom and resubmitting out of habit.

I see no reason not to hide the submit button at the bottom in the event that Koha is asking for confirmation about duplicate patrons.
Comment 1 Kyle M Hall 2012-10-03 14:49:02 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2012-10-04 08:18:48 UTC
Created attachment 12672 [details] [review]
Bug 8869 - Duplicate member check doesn't disable submit button on bottom.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

I confirm that after applying this patch, the submit button is removed from
patron edit page, avoiding accidentaly clicking on it, without responding to
the question about possible duplicate patron?
Comment 3 Paul Poulain 2012-10-12 19:42:55 UTC
QA comment
 * tiny patch, T::T only

passed QA
Comment 4 Paul Poulain 2012-10-12 19:43:54 UTC
Patch pushed to master
Comment 5 Chris Cormack 2012-10-14 07:37:50 UTC
Pushed to 3.8.x will be in 3.8.6