- Note field (3xx) are not displayed on search result page. We get 'HASH()' text. - Parallel/Other forms (7xx) are not displayed, with language name in front of heading - On result page, seealso form are displayed, and end with '--' This bug is present on 3.8.5. To fix it, several patches only available on HEAD are necessary.
Created attachment 12664 [details] [review] UNIMARC authorities search doesn't display properly information - Note field (3xx) are not displayed on search result page. We get 'HASH()' text. - Parallel/Other forms (7xx) are not displayed, with language name in front of heading - On result page, seealso form are displayed, and end with '--' This bug is present on 3.8.5. To fix it, several patches only available on HEAD are necessary.
> This bug is present on 3.8.5. To fix it, several patches only available > on HEAD are necessary. What does this mean .. this patch is unnessecary, or does it needs other patches? If so which ones?
> What does this mean .. this patch is unnessecary, or does it needs other > patches? If so which ones? Bug 8523 seems enough.
Created attachment 12671 [details] [review] UNIMARC authorities search doesn't display properly information - Note field (3xx) are not displayed on search result page. We get 'HASH()' text. - Parallel/Other forms (7xx) are not displayed, with language name in front of heading, both on result and detail page. - Note are not displayed. - On result page, seealso form are displayed, but end with a superfluous '--' - Style the result page, with condensed block, and space between them. To be applied on 3.8.x after bug 8523.
Created attachment 12677 [details] [review] Proposed patch
Created attachment 12683 [details] [review] Bug 8870 UNIMARC authorities search doesn't display information properly - Note field (3xx) are not displayed on search result page. We get 'HASH()' text. - Parallel/Other forms (7xx) are not displayed, with language name in front of heading, both on result and detail page. - Note are not displayed. - On result page, seealso form are displayed, but end with a superfluous '--' - Style the result page, with condensed block, and space between them. - Done both on OPAC/staff To be applied on 3.8.x after bug 8523. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
QA comment: * patch applies, passes koha-qa.pl, work well * digging for any side effect, I was wondering what was the reason for: +[% BLOCK language %] + [% SWITCH lang %] + [% CASE ['en', 'eng'] %]English + [% CASE ['fr', 'fre'] %]French + [% CASE ['it', 'ita'] %]Italian + [% CASE ['de', 'ger', 'deu'] %]German + [% CASE ['es', 'spa'] %]Spanish + [% CASE %][% lang %] + [% END %] +[% END %] (in cunjunction with + [% PROCESS language lang=otherscrip.lang | trim %]: ) Other question: does this patch remove the use of auth_types.summary we had before ? (I think, but want a confirmation)
> * digging for any side effect, I was wondering what was the reason for: > +[% BLOCK language %] > + [% SWITCH lang %] > + [% CASE ['en', 'eng'] %]English > + [% CASE ['fr', 'fre'] %]French > + [% CASE ['it', 'ita'] %]Italian UNIMARC authorities can contain translated headings. The language is coded in a subfield. The template decodes it, and so it's translatable. If required, more language codes could be added. 2 and 3 letters codes are "acceptable". > Other question: does this patch remove the use of auth_types.summary we had > before ? (I think, but want a confirmation) It has already been done by Jared patch: bug 8523.
passed QA (see comment 7 for my QA, and comment 8 for Frederic answer) passing QA before string freeze
Patch pushed to master (3.10 only, it's a bugfix for a 3.10 feature)
Good patch! But I can still see a VERY cosmetic problem in authorities search : superflous ";" for some authorities Should I create a new bug, or just comment this one ? Ex : " Écologie des jardins ; ; ; BT: Écologie agricole" " Grottes de jardin ; ; BT: Grottes ; BT: Fabriques de jardin " Mathieu Saby Rennes 2 university.
> Should I create a new bug, or just comment this one ? You should better create a new bug, and attach sample data to it: a mysqldump of authorities records from auth_header table.
For 3.8.x users, you may want to hide those HASH texts. I noticed they only occur in span with "note" class. So I hide them with CSS : OPACUserCSSS: #userauthsearchresults .note { display: none; } IntranetUserCSS : #authorities_searchresultlist_results .note, #auth_searchresultlist_auth .note { display: none; }
Was released in 3.10.0