Bug 8873 - JavaScript error in Opac displaying tag cloud
Summary: JavaScript error in Opac displaying tag cloud
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Marc Véron
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-04 09:32 UTC by Marc Véron
Modified: 2013-05-23 06:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8873 - JavaScript error in Opac displaying tag cloud (948 bytes, patch)
2012-10-04 09:37 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 8873 - JavaScript error in Opac displaying tag cloud (1005 bytes, patch)
2012-10-04 11:41 UTC, Mirko Tietgen
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2012-10-04 09:32:26 UTC
On master (3.09.00.060), I get a JavaScript error on line 126 in opac-tags.pl while displaying tags cloud.

Reason: There are two lines with closing });

<script type="text/javascript">
//<![CDATA[
		$("#mytagst").tablesorter({
    dateFormat: 'uk',
            widgets : ['zebra'],
			headers: { 3: { sorter: false }},
            sortList: [[2,0]]
        });
	});
//]]>

Patch follows.
Comment 1 Marc Véron 2012-10-04 09:37:19 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2012-10-04 11:41:52 UTC
Created attachment 12682 [details] [review]
Bug 8873 - JavaScript error in Opac displaying tag cloud

On master (3.09.00.060), I get a JavaScript error on line 126 in opac-tags.pl while displaying tags cloud.

Reason: There are two lines with closing });

Patch removes one line.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Comment 3 Mirko Tietgen 2012-10-04 11:42:21 UTC
Removes the error. Signed off.
Comment 4 Paul Poulain 2012-10-12 20:49:16 UTC
QA comment: very tiny patch.

This bug exist since march 2011 git blame says (patch 77b64098)
Surprising that no-one spotted it before !!!

passed QA
Comment 5 Paul Poulain 2012-10-12 20:49:30 UTC
Patch pushed to master
Comment 6 Chris Cormack 2012-10-17 19:41:32 UTC
Pushed to 3.8.x, will be in 3.8.6