Bug 8890 - Packages can't be built on master, db dependent test
Summary: Packages can't be built on master, db dependent test
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P1 - high blocker (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on: 8846
Blocks: 8924
  Show dependency treegraph
 
Reported: 2012-10-09 01:40 UTC by Chris Cormack
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8890 - C4::Holdsqueue is db dependent (693 bytes, patch)
2012-10-09 01:41 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 8890: C4/HoldsQueue requires DB (2.13 KB, patch)
2012-10-16 09:20 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 8890: don't try to load DB-dependent modules (1.23 KB, patch)
2012-10-16 09:20 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 8890: don't try to load DB-dependent modules (884 bytes, patch)
2012-10-16 09:43 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN (1.14 KB, patch)
2012-10-16 09:43 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 8890: C4/HoldsQueue requires DB (2.19 KB, patch)
2012-10-17 06:53 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 8890: don't try to load DB-dependent modules (942 bytes, patch)
2012-10-17 06:55 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN (1.19 KB, patch)
2012-10-17 06:56 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 8890 - move two more db dependent tests (969 bytes, patch)
2012-10-24 05:52 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2012-10-09 01:40:38 UTC

    
Comment 1 Chris Cormack 2012-10-09 01:41:20 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2012-10-16 09:20:23 UTC Comment hidden (obsolete)
Comment 3 Jared Camins-Esakov 2012-10-16 09:20:43 UTC Comment hidden (obsolete)
Comment 4 Jared Camins-Esakov 2012-10-16 09:43:30 UTC Comment hidden (obsolete)
Comment 5 Jared Camins-Esakov 2012-10-16 09:43:38 UTC Comment hidden (obsolete)
Comment 6 Chris Cormack 2012-10-17 06:53:17 UTC
Created attachment 12872 [details] [review]
Bug 8890: C4/HoldsQueue requires DB

This counter-patch moves all database handling code into subroutines
in C4::HoldsQueue. This fixes the test, and is required for persistent
environments like Plack.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 7 Chris Cormack 2012-10-17 06:55:49 UTC
Created attachment 12873 [details] [review]
Bug 8890: don't try to load DB-dependent modules

C4::Members::Statistics uses the database in its BEGIN {} block,
which breaks the package build process. This patch causes it to be
skipped in the 00-load test.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 8 Chris Cormack 2012-10-17 06:56:52 UTC
Created attachment 12874 [details] [review]
Bug 8890: Koha::Borrower::Files shouldn't use db in BEGIN

This patch removes the usage of the database in Koha::Borrower::Files'
BEGIN block. It also removes the export-related declarations, since
they were unused, and unnecessary in a module called in an object-oriented
fashion.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 9 Robin Sheat 2012-10-24 05:52:57 UTC
Created attachment 13014 [details] [review]
Bug 8890 - move two more db dependent tests

* t/AuthoritiesMarc.t
* t/SuggestionEngine_ExplodedTerms.t
Comment 10 Jared Camins-Esakov 2012-10-24 12:42:24 UTC
The patch for bug 8846 corrects the problem with t/SuggestionEngine_ExplodedTerms.t.
Comment 11 Jonathan Druart 2012-10-24 13:30:31 UTC
These patchs fix the t/00-load.t test
Marked as Passed QA.
Comment 12 Paul Poulain 2012-10-24 15:54:21 UTC
Patch pushed to master

The 1st patch ( Bug 8890: C4/HoldsQueue requires DB (2.19 KB, patch) )
could be pushed to 3.8 to improve Plack compatibility, I think others won't apply because related to 3.10 patches
Comment 13 Robin Sheat 2012-10-25 02:39:18 UTC
I'll change my patch to give bug 8846 priority over it, as it fixes it properly (my goal is mostly to get things building.)
Comment 14 Robin Sheat 2012-10-25 02:46:34 UTC
Oh, I see all patches were pushed to master. Disregard what I said there then.
Comment 15 Chris Cormack 2013-04-21 08:12:11 UTC
Released in 3.10.0