Variable "$basketno" is not available at /home/paul/koha.dev/koha-community/acqui/basket.pl line 359.
Created attachment 13188 [details] [review] Bug 8892 fix Plack scoping in acquisition basket.pl has a local sub get_order_infos that require our-ing the $basketno variable Note that I had no problem with this variable. It may be some dead code, but I couldn't be sure it is, so I just switched basketno to "our" neworderempty.pl has 2 local sub that require our-ing some variables: subs MARCfindbreeding and Load_Duplicate
I never had any problem with this variable scoping problems, so maybe it's some unused variable, but for safety (and having a quiet log), it's better to fix by our-ing some variables
Created attachment 13374 [details] [review] Bug 8892 fix Plack scoping in acquisition basket.pl has a local sub get_order_infos that require our-ing the basketno variable. Note that I had no problem with this variable. It may be some dead code, but I couldn't be sure it is, so I just switched basketno to "our" neworderempty.pl has 2 local sub that require our-ing some variables: subs MARCfindbreeding and Load_Duplicate Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
QA comment: This patch removes warnings in 2 pages (using Plack). Marked as Passed QA.
This patch has been pushed to master.
Patch pushed to branch 3.10.x
Released in 3.10.0