Bug 8898 - Remove unused mainmenu include and related styles in the staff client
Summary: Remove unused mainmenu include and related styles in the staff client
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Paul Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 18:30 UTC by Owen Leonard
Modified: 2013-12-05 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8898 - Remove unused mainmenu include and related styles in the staff client (5.80 KB, patch)
2012-10-10 19:04 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8898 - Remove unused mainmenu include and related styles in the staff client (5.87 KB, patch)
2012-10-12 13:39 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-10-10 18:30:27 UTC
There is an unused include file, mainmenu.inc, and related CSS which can be removed.
Comment 1 Owen Leonard 2012-10-10 18:35:46 UTC
A similar file, additem-menu.inc should be removed also.
Comment 2 Owen Leonard 2012-10-10 19:04:40 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2012-10-12 13:39:10 UTC
Created attachment 12784 [details] [review]
[SIGNED-OFF] Bug 8898 - Remove unused mainmenu include and related styles in the staff client

This patch removes the mainmenu and additem-menu includes and #navigation
references in staff-global.css which were used by those includes.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Kyle M Hall 2012-10-12 13:39:57 UTC
Applied patch, checked many different pages, no ill effects were percieved.
Comment 5 Paul Poulain 2012-10-22 15:20:02 UTC
QA comment:
 * remove things only (but some string, thus QAing before String Freeze)
 * grep mainmenu.inc and additem-menu show it's not used anymore

passed QA
Comment 6 Paul Poulain 2012-10-22 15:20:17 UTC
Patch pushed to master
Comment 7 Chris Cormack 2012-10-22 21:51:58 UTC
Pushed to 3.8.x, will be in 3.8.7