Bug 8899 - Remove unused CSS declarations from staff client CSS
Summary: Remove unused CSS declarations from staff client CSS
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.12
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 19:00 UTC by Owen Leonard
Modified: 2013-05-23 06:23 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8899 - Remove unused CSS declarations from staff client CSS (5.20 KB, patch)
2012-10-12 15:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8899 - Remove unused CSS declarations from staff client CSS (5.22 KB, patch)
2012-10-18 06:54 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 8899 [Revised] Remove unused CSS declarations from staff client CSS (4.56 KB, patch)
2012-11-01 12:50 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8899 [Revised] Remove unused CSS declarations from staff client CSS (4.61 KB, patch)
2012-11-09 15:44 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-10-10 19:00:52 UTC
The main staff client CSS file, staff-global.css, is getting pretty old now. It's time we checked to see if there are elements which can be safely removed.
Comment 1 Owen Leonard 2012-10-12 15:33:45 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-10-18 06:54:10 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2012-10-25 14:08:57 UTC
I see 2 rules already in use:

members/moremember.tt: <span class="problem"><a href="/cgi-bin/koha/members/member-password.pl?member=[% borrowernumber %]">Undefined</a></span>

modules/reports/guided_reports_start.tt: $(this).parents('tr').attr("class","warn");
Comment 4 Paul Poulain 2012-10-25 16:44:43 UTC
(In reply to comment #3)
> I see 2 rules already in use:
already or still in use ?

does it mean failed QA ?
Comment 5 Jonathan Druart 2012-10-26 07:25:56 UTC
(In reply to comment #4)

> already or still in use ?
Yes, sorry :-/

> does it mean failed QA ?
No, it is not failed QA, but I would like to have the Owen's point of view. If I drop the "Signed off" status, others QAers  will not be able to give their opinion afterwards.
Comment 6 Mason James 2012-11-01 09:59:10 UTC
(In reply to comment #3)
> I see 2 rules already in use:
> 
> members/moremember.tt: <span class="problem"><a
> href="/cgi-bin/koha/members/member-password.pl?member=[% borrowernumber
> %]">Undefined</a></span>
> 
> modules/reports/guided_reports_start.tt:
> $(this).parents('tr').attr("class","warn");

well spotted :)

so we need a new patch that does not delete those 2 rules
Comment 7 Owen Leonard 2012-11-01 12:50:17 UTC Comment hidden (obsolete)
Comment 8 Kyle M Hall 2012-11-09 15:44:18 UTC
Created attachment 13356 [details] [review]
[SIGNED-OFF] Bug 8899 [Revised] Remove unused CSS declarations from staff client CSS

Using an add-on for Firefox called CSS Usage I found some
instances of CSS in staff-global.css which are unused. Unused
selectors were confirmed by a search of the code.

Testers can't exactly check the whole staff client for things
which look off, but can confirm by their own search that
the removed CSS has no corresponding markup.

Revision adds back lines which were discoverd by QA to be in use.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Kyle M Hall 2012-11-09 15:44:58 UTC
Applied patch, ran though various staff pages, no adverse effects detected.
Comment 10 Jonathan Druart 2012-11-20 16:10:24 UTC
Looks good now.
Marked as Passed QA.
Comment 11 Jared Camins-Esakov 2012-11-23 18:38:33 UTC
This patch has been pushed to master.