The main staff client CSS file, staff-global.css, is getting pretty old now. It's time we checked to see if there are elements which can be safely removed.
Created attachment 12794 [details] [review] Bug 8899 - Remove unused CSS declarations from staff client CSS Using an add-on for Firefox called CSS Usage I found some instances of CSS in staff-global.css which are unused. Unused selectors were confirmed by a search of the code. Testers can't exactly check the whole staff client for things which look off, but can confirm by their own search that the removed CSS has no corresponding markup.
Created attachment 12896 [details] [review] Bug 8899 - Remove unused CSS declarations from staff client CSS Using an add-on for Firefox called CSS Usage I found some instances of CSS in staff-global.css which are unused. Unused selectors were confirmed by a search of the code. Testers can't exactly check the whole staff client for things which look off, but can confirm by their own search that the removed CSS has no corresponding markup. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I see 2 rules already in use: members/moremember.tt: <span class="problem"><a href="/cgi-bin/koha/members/member-password.pl?member=[% borrowernumber %]">Undefined</a></span> modules/reports/guided_reports_start.tt: $(this).parents('tr').attr("class","warn");
(In reply to comment #3) > I see 2 rules already in use: already or still in use ? does it mean failed QA ?
(In reply to comment #4) > already or still in use ? Yes, sorry :-/ > does it mean failed QA ? No, it is not failed QA, but I would like to have the Owen's point of view. If I drop the "Signed off" status, others QAers will not be able to give their opinion afterwards.
(In reply to comment #3) > I see 2 rules already in use: > > members/moremember.tt: <span class="problem"><a > href="/cgi-bin/koha/members/member-password.pl?member=[% borrowernumber > %]">Undefined</a></span> > > modules/reports/guided_reports_start.tt: > $(this).parents('tr').attr("class","warn"); well spotted :) so we need a new patch that does not delete those 2 rules
Created attachment 13174 [details] [review] Bug 8899 [Revised] Remove unused CSS declarations from staff client CSS Using an add-on for Firefox called CSS Usage I found some instances of CSS in staff-global.css which are unused. Unused selectors were confirmed by a search of the code. Testers can't exactly check the whole staff client for things which look off, but can confirm by their own search that the removed CSS has no corresponding markup. Revision adds back lines which were discoverd by QA to be in use.
Created attachment 13356 [details] [review] [SIGNED-OFF] Bug 8899 [Revised] Remove unused CSS declarations from staff client CSS Using an add-on for Firefox called CSS Usage I found some instances of CSS in staff-global.css which are unused. Unused selectors were confirmed by a search of the code. Testers can't exactly check the whole staff client for things which look off, but can confirm by their own search that the removed CSS has no corresponding markup. Revision adds back lines which were discoverd by QA to be in use. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Applied patch, ran though various staff pages, no adverse effects detected.
Looks good now. Marked as Passed QA.
This patch has been pushed to master.