When trying to receive an order (partially or not), I got this message in log finishreceive.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_community_master`.`aqorders`, CONSTRAINT `aqorders_ibfk_3` FOREIGN KEY (`invoiceid`) REFERENCES `aqinvoices` (`invoiceid`) ON DELETE SET NULL ON UPDATE CASCADE) at /home/julian/koha/versions/community-master/C4/Acquisition.pm line 1344 and order is not received. This is because invoicenumber is passed to ModReceiveOrder instead of invoiceid. Bug is introduced by Bug 5335 (unhappy rebase) I'll submit a patch in a couple of minutes.
Created attachment 12770 [details] [review] Bug 8903: Pass invoiceid to ModReceiveOrder
*** Bug 8929 has been marked as a duplicate of this bug. ***
Created attachment 12855 [details] [review] [SIGNED-OFF] Bug 8903: Pass invoiceid to ModReceiveOrder Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
QA Comment: The routine ModReceiveOrder takes an invoiceid, not an invoicenumber. Simple fix for a big issue. Marked as Passed QA.
Obvious bugfix, patch pushed
Ok in master. Bug not present in stable. Marked as resolved.