Bug 8905 - Error when accessing invalid authority
Summary: Error when accessing invalid authority
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low major
Assignee: Jared Camins-Esakov
QA Contact: Paul Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-11 19:02 UTC by Jared Camins-Esakov
Modified: 2013-12-05 20:06 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8905: Error when accessing invalid authority (1007 bytes, patch)
2012-10-11 19:04 UTC, Jared Camins-Esakov 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8905: Error when accessing invalid authority (1.10 KB, patch)
2012-10-12 13:35 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2012-10-11 19:02:16 UTC 
The GetAuthority shim does not check that authority retrieval was successful, and therefore can call ->record on an undefined value.

This can be reproduced by trying to load an invalid authority record using bulkmarcimport.
Comment 1 Jared Camins-Esakov 2012-10-11 19:04:22 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall (khall) 2012-10-12 13:35:21 UTC 
Created attachment 12783 [details] [review]
[SIGNED-OFF] Bug 8905: Error when accessing invalid authority

The GetAuthority shim does not check that authority retrieval was
successful, and therefore can call ->record on an undefined value.

This can be reproduced by trying to load an invalid authority record
using bulkmarcimport. There may be other ways to trigger it, but I'm
not sure what they are.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Paul Poulain 2012-10-25 13:04:36 UTC 
QA comment: one-line patch, fixes an annoying error that should not happen, but of course, does sometimes
Comment 4 Paul Poulain 2012-10-25 13:04:50 UTC 
Patch pushed to master
Comment 5 Chris Cormack 2012-10-27 01:16:03 UTC 
This doesn't apply to 3.8.x
Comment 6 Chris Cormack 2013-04-21 08:10:36 UTC 
Released in 3.10.0