Bug 8906 - Improve OAI management interface
Summary: Improve OAI management interface
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 9201
  Show dependency treegraph
 
Reported: 2012-10-11 19:17 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8906 - Improve OAI management interface (13.20 KB, patch)
2012-10-11 19:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8906 - Improve OAI management interface (13.21 KB, patch)
2012-10-18 07:05 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 8906: Followup FIX hardcoded localhost url (2.82 KB, patch)
2012-11-20 15:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 8906: Followup FIX hardcoded localhost url (2.84 KB, patch)
2012-12-13 22:29 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 8906: Followup replace 'Clear' with 'Delete' (1.42 KB, patch)
2012-12-26 11:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8906: Followup replace 'Clear' with 'Delete' (1.51 KB, patch)
2012-12-27 15:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8906 - Improve OAI management interface (13.31 KB, patch)
2013-02-15 10:38 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 8906: Followup FIX hardcoded localhost url (2.94 KB, patch)
2013-02-15 10:38 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 8906: Followup replace 'Clear' with 'Delete' (1.56 KB, patch)
2013-02-15 10:38 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-10-11 19:17:27 UTC
The OAI management interface breaks with existing interface patterns in several way. I propose to correct these differences and improve the handling of clone and delete operations in set descriptions and mappings.
Comment 1 Owen Leonard 2012-10-11 19:21:55 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-10-18 07:05:21 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2012-11-20 15:42:25 UTC Comment hidden (obsolete)
Comment 4 Mirko Tietgen 2012-12-13 22:25:34 UTC
Jonathan,

I can't find any reference to localhost in that file. Maybe this was fixed with some other patch already?
Comment 5 Mirko Tietgen 2012-12-13 22:27:03 UTC
Ah, my bad. I had applied both patches already :)
Comment 6 Mirko Tietgen 2012-12-13 22:29:18 UTC Comment hidden (obsolete)
Comment 7 Mirko Tietgen 2012-12-13 22:44:47 UTC
Hey Owen,

now that I had a look at it again, wouldn't it be more straightforward to replace the 'clear' button with a 'replace' button that clears, saves and thus deletes the row?
Comment 8 Owen Leonard 2012-12-20 13:54:42 UTC
(In reply to comment #7)

> now that I had a look at it again, wouldn't it be more straightforward to
> replace the 'clear' button with a 'replace' button that clears, saves and
> thus deletes the row?

I don't understand.
Comment 9 Mirko Tietgen 2012-12-20 17:32:00 UTC
Oh, sorry, I meant to write 'delete', not 'replace'.

The 'clear' button now clears the fields and I was wondering if it would make sense to clear and save, which would result in a deletion. I hope i worded it better this time.
Comment 10 Jonathan Druart 2012-12-26 11:07:46 UTC
Owen,

What do you think about Mirko's proposition?
I think he is right, but I let you give you opinion.
I will submit a patch with this modification, please signoff or mark it as obsolete if you want.
Comment 11 Jonathan Druart 2012-12-26 11:07:56 UTC Comment hidden (obsolete)
Comment 12 Owen Leonard 2012-12-27 15:58:44 UTC Comment hidden (obsolete)
Comment 13 Marcel de Rooy 2013-02-15 10:15:28 UTC
QA: Looking at this one now.
Comment 14 Marcel de Rooy 2013-02-15 10:38:17 UTC
Created attachment 15338 [details] [review]
Bug 8906 - Improve OAI management interface

Revising OAI configuration interface to conform to
existing interface patterns:

- Properly-formatted form rows
- "clone" and "clear" links consistent with other
  forms which use these conventions
- Improved title and breadcrumbs
- Standard save and cancel markup

New to the mappings interface: A "clear" button
to remove or empty the contents of a row. This replaces
the help text about emptying fields.

To test: view, add and edit OAI sets and mappings. Try adding
and removing multiple set descriptions and mappings.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 15 Marcel de Rooy 2013-02-15 10:38:42 UTC
Created attachment 15339 [details] [review]
Bug 8906: Followup FIX hardcoded localhost url

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 16 Marcel de Rooy 2013-02-15 10:38:48 UTC
Created attachment 15340 [details] [review]
Bug 8906: Followup replace 'Clear' with 'Delete'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 17 Marcel de Rooy 2013-02-15 10:39:43 UTC
QA Comment:
Looks good to me. Improving interface.
Just wondering ("somewhat" outside the scope): Deleting a set is without confirmation? 
I agree that clearing one line in a set does not need a confirm, but before deleting possibly lots of lines..? 

Passed QA
Comment 18 Jared Camins-Esakov 2013-02-15 14:08:32 UTC
This patch has been pushed to master.