When opening about, three error log entries were triggered. Two were silent warnings, and an entry caused by this file not being there. Upon further research, I discovered that the entire docs directory was not in /usr/share/koha/intranet/cgi/docs as it is expected by the about.pl module. I copied the docs directory from the tarball, and the error disappeared. I believe it is a packaging issue which should be fixed on a forward basis.
Assigned to Robin, as per his instructions.
So, this appears to be a larger issue: if I do a makefile install, history.txt isn't installed anywhere.
Created attachment 19354 [details] [review] Bug 8911 - history.txt file missing for about.pl This patch makes Makefile.PL put the history.txt file in the right places depending on the chosen setup layout, adds a reference to that place in koha-conf.xml (and debian template version), and finally tweaks about.pl to use it. To test, apply the patch and verify that perl Makefile.PL runs fine, and installing in - dev - single - standard layouts works as expected. Then go to the about.pl page and see if Koha's history shows there. Then, build your packages and test on your newly created instances. Regards To+
Created attachment 19452 [details] [review] Bug 8911 - history.txt file missing for about.pl This patch makes Makefile.PL put the history.txt file in the right places depending on the chosen setup layout, adds a reference to that place in koha-conf.xml (and debian template version), and finally tweaks about.pl to use it. To test, apply the patch and verify that perl Makefile.PL runs fine, and installing in - dev - single - standard layouts works as expected. Then go to the about.pl page and see if Koha's history shows there. Then, build your packages and test on your newly created instances. Regards To+ Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Robin, could you take a look at this please? :)
Created attachment 19827 [details] [review] [PASSED QA] Bug 8911 - history.txt file missing for about.pl This patch makes Makefile.PL put the history.txt file in the right places depending on the chosen setup layout, adds a reference to that place in koha-conf.xml (and debian template version), and finally tweaks about.pl to use it. To test, apply the patch and verify that perl Makefile.PL runs fine, and installing in - dev - single - standard layouts works as expected. Then go to the about.pl page and see if Koha's history shows there. Then, build your packages and test on your newly created instances. Regards To+ Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Pushed to master. Thanks, Tomás!
This patch has been pushed to 3.12.x, will be in 3.12.2. Added a followup that advertises the change for people updating to add the line to koha-conf.xml manually.
Pushed to 3.10.x, will be in 3.10.10
When just upgrading your dev install, you now lose the contents of the timeline page on about. With warnings like: about.pl: Use of uninitialized value $docdir in string at /usr/share/koha/testclone/about.pl line 152. about.pl: readline() on closed filehandle $file at /usr/share/koha/testclone/about.pl line 158.
Please see bug 10915