Bug 8914 - Blank search that returns invalid authorities fails under Plack
Summary: Blank search that returns invalid authorities fails under Plack
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Jared Camins-Esakov
QA Contact: Paul Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-13 02:42 UTC by Jared Camins-Esakov
Modified: 2013-12-05 20:01 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8914: Blank search that returns invalid authorities fails under Plack (1.77 KB, patch)
2012-10-13 02:50 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 8914: Blank search that returns invalid authorities fails under Plack (1.82 KB, patch)
2012-10-18 06:47 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2012-10-13 02:42:43 UTC
When doing a search with no terms for the default authority type under Plack, you will get a segfault if it returns any records that do not have any authority type. As far as I can tell, this cannot be reproduced under CGI/Apache.
Comment 1 Jared Camins-Esakov 2012-10-13 02:50:24 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-10-18 06:47:53 UTC
Created attachment 12895 [details] [review]
Bug 8914: Blank search that returns invalid authorities fails under Plack

When doing a search with no terms for the default authority type under
Plack, you will get a segfault if it returns any records that do not
have any authority type. As far as I can tell, this cannot be reproduced
under CGI/Apache.

To test:
Confirm that you don't get an error if you click the Submit button in
the authorities sections in the staff client and OPAC without entering
a term or changing the authority type.

You may or may not be able to reproduce the problem prior to applying
the patch, but that is the only situation in which I managed to trigger
it.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Paul Poulain 2012-10-25 16:42:25 UTC
QA Comment:
 * tiny patch
 * just moves a call to a sub outside of a nested x?y:z
 * can't reproduce the bad behaviour on my plack setup, but everything still OK after patch applied
 * passes koha-qa.pl

passed QA
Comment 4 Paul Poulain 2012-10-25 16:42:53 UTC
Patch pushed to master
Comment 5 Jared Camins-Esakov 2012-12-03 13:14:11 UTC
I no longer get the error that precipitated this bug report.