That's the 1st bug I create in bugzilla, so I hope I've understood the workflow... The problem : This bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5192 as created a "curriculum" index for 658 field in zebra, and a search option in Advanced search (under More Options) for this field. Now the "curriculum" only exists in Marc21 (and maybe Normac?) but has no equivalent in Unimarc. So the "curriculum" option must be hidden in advanced search if marcflavor is set to Unimarc. M. Saby Rennes 2 university
Created attachment 12800 [details] [review] Hide Curriculum index in advanced search if marcflavor = unimarc Here is my 1st patch. Hope it works... To test - set marcflavour to UNIMARC, this option should be hidden in the index list in opac and staff interface advanced search - set marcflavour to MARC21, this option should be visible, as before M. Saby Rennes 2 university
Created attachment 12801 [details] [review] Bug 8916: Hide Curriculum index in advanced search if marcflavor = unimarc This patch hides curriculum option value in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc and koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt if marcflavor = UNIMARC To test - set marcflavour to UNIMARC, this option should be hidden in the index list in opac and staff interface advanced search - set marcflavour to MARC21, this option should be visible, as before Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
QA comment * tiny patch, template only, no side-effect risk * passes koha-qa.pl * add a string... in the follow-up adding you as a contributor * just a comment = IF (x!=y) can also be written UNLESS (x=y), and we usually uses that in Koha. But it's not enforced by a coding guideline, and I don't think we should add this rule. passed QA
Patch pushed to master, Welcome to the contributor's list Mathieu, you're 193th !
Thanks Paul! I was looking for an idea for a tattoo. Maybe a big "193th" in the back... Mathieu
Released in 3.10.0