Bug 8916 - Hide Curriculum index in advanced search for unimarc marcflavor
Summary: Hide Curriculum index in advanced search for unimarc marcflavor
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low minor (vote)
Assignee: Mathieu Saby
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-13 17:58 UTC by Mathieu Saby
Modified: 2013-12-05 20:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Hide Curriculum index in advanced search if marcflavor = unimarc (2.26 KB, patch)
2012-10-13 18:07 UTC, Mathieu Saby
Details | Diff | Splinter Review
Bug 8916: Hide Curriculum index in advanced search if marcflavor = unimarc (2.29 KB, patch)
2012-10-13 20:28 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2012-10-13 17:58:21 UTC
That's the 1st bug I create in bugzilla, so I hope I've understood the workflow...
The problem :
This  bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5192 as created a "curriculum" index for 658 field in zebra, and a search option in Advanced search (under More Options) for this field.
Now the "curriculum" only exists in Marc21 (and maybe Normac?) but has no equivalent in Unimarc.
So the "curriculum" option must be hidden in advanced search if marcflavor is set to Unimarc.

M. Saby
Rennes 2 university
Comment 1 Mathieu Saby 2012-10-13 18:07:41 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-10-13 20:28:16 UTC
Created attachment 12801 [details] [review]
Bug 8916: Hide Curriculum index in advanced search if marcflavor = unimarc

This patch hides curriculum option value in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc and koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt if marcflavor = UNIMARC

To test
- set marcflavour to UNIMARC, this option should be hidden in the index list in opac and staff interface advanced search
- set marcflavour to MARC21, this option should be visible, as before

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Paul Poulain 2012-10-22 15:27:20 UTC
QA comment
 * tiny patch, template only, no side-effect risk
 * passes koha-qa.pl
 * add a string... in the follow-up adding you as a contributor
 * just a comment = IF (x!=y) can also be written UNLESS (x=y), and we usually uses that in Koha. But it's not enforced by a coding guideline, and I don't think we should add this rule.

passed QA
Comment 4 Paul Poulain 2012-10-22 15:31:31 UTC
Patch pushed to master, Welcome to the contributor's list Mathieu, you're 193th !
Comment 5 Mathieu Saby 2012-10-22 16:16:12 UTC
Thanks Paul!
I was looking for an idea for a tattoo. Maybe a big "193th" in the back...

Mathieu
Comment 6 Chris Cormack 2013-04-21 07:36:41 UTC
Released in 3.10.0