Bug 8923 - Add ids to repeated pagination menus to allow for CSS customization
Summary: Add ids to repeated pagination menus to allow for CSS customization
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 16:52 UTC by Owen Leonard
Modified: 2013-12-05 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8923 - Add ids to repeated pagination menus to allow for CSS customization (4.84 KB, patch)
2012-10-15 17:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8923 [Revised] Add ids to repeated pagination menus to allow for CSS customization (2.58 KB, patch)
2012-10-15 17:22 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8923 [Revised] Add ids to repeated pagination menus to allow for CSS customization (2.61 KB, patch)
2012-10-16 17:16 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-10-15 16:52:53 UTC
Bug 8597 added another set of pagination links to the top of the OPAC search results page in the prog templates. It should be possible to hide this with CSS.
Comment 1 Owen Leonard 2012-10-15 17:16:09 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-10-15 17:22:24 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2012-10-16 17:16:20 UTC
Created attachment 12861 [details] [review]
[SIGNED-OFF] Bug 8923 [Revised] Add ids to repeated pagination menus to allow for CSS customization

This patch adds ids to each pagination menu on the OPAC search
results page so that they can be customized via CSS or JavaScript.

To test, modify OpacUserCSS to hide ids "top-pages" and "bottom-pages"
and confirm that they are hidden.

Also fixed is an unescaped ampersand introduced by Bug 8209.

Revision removes debugging changes to an unrelated file.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 4 Paul Poulain 2012-10-22 15:45:23 UTC
QA comment
 * tiny patch, template only
 * passes koha-qa.pl

passed QA
Comment 5 Paul Poulain 2012-10-22 15:45:55 UTC
Patch pushed to master
Comment 6 Chris Cormack 2012-10-22 22:07:42 UTC
Does not apply on 3.8.x, please send a new patch if we need this fix there
Comment 7 Owen Leonard 2012-11-21 20:19:39 UTC
(In reply to comment #6)
> Does not apply on 3.8.x, please send a new patch if we need this fix there

Not applicable to 3.8.x.