Currently, the label-manage.pl has a table that is sorted by the label id ( i.e. by the order in which the rows were inserted into the database ). This sorting is not very useful. It would be better to allow sorting, and to sort by name by default.
Created attachment 12912 [details] [review] Bug 8943 - Add table sorting to labels
Created attachment 13148 [details] [review] Bug 8943 - Add table sorting to labels
Created attachment 13180 [details] [review] Bug 8943 - Add table sorting to labels - Followup - Sort pulldowns in batch export.
Created attachment 13299 [details] [review] [Signed off] Bug 8943 - Add table sorting to labels - Followup - Sort pulldowns in batch export. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
I applied these patches and tested. I can confirm that the label layouts, templates and profiles are now sorted by the "name" column alphabetically by default. The sort buttons on the various columns work correctly. The pulldown menu when you go to export a batch is also correctly sorted alphabetically by default. The only thing I thought was weird (not necessarily wrong, but kind of weird) was that the batches appear to be sorted by "item count" by default. Is that useful? I would think batches might be the one place where keeping them in order of batch id might be better, although you can, of course, easily use the column sort to put them in that order if you want them that way. I will add my signoff since these patches apply and work as advertised, but this also requires non-ByWater testing and signoff. I hope the next tester will consider my question above about batch id vs. item count and voice an opinion on what would be more useful. Thanks, Melia
I have tested this and it works the way I would expect it to. Nora Blake
Created attachment 15992 [details] [review] [Signed off] Bug 8943 - Add table sorting to labels - Followup - Sort pulldowns in batch export. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Nora Blake <nblake@masslibsystem.org>
Hhmm... Well, I intended to sign off on both the original patch and the follow up patch for both Nora and me, but I can only seem to get the sign off onto the follow up patch. I am not succeeding with git-bz on this Friday afternoon. I'm sorry! Please consider them both signed off.
Created attachment 15993 [details] [review] [Signed off] Bug 8943 - Add table sorting to labels - Followup - Sort pulldowns in batch export. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Nora Blake <nblake@masslibsystem.org>
Created attachment 15994 [details] [review] [Signed off] Bug 8943 - Add table sorting to labels Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off by: Nora Blake <nblake@masslibsystem.org>
Created attachment 17079 [details] [review] [PASSED QA] Bug 8943 - Add table sorting to labels Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off by: Nora Blake <nblake@masslibsystem.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17080 [details] [review] [PASSED QA] Bug 8943 - Add table sorting to labels - Followup - Sort pulldowns in batch export. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Nora Blake <nblake@masslibsystem.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass.
This patch has been pushed to master.