Hi In the 2 subtypes_unimarc.inc template files for opac and staff interface, there are 2 little mistakes : - label "Feschrift Ind." for the index "Literature-Code" (fiction, short stories etc) => Should be "Literary genre" or something like that. - option value Frequency-code:i = Other => Should be Frequency-code:z = Other There is a also a few typos, and some missing values for some indexes : Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g) M. Saby Rennes 2 University
Created attachment 12936 [details] [review] [PATCH] Bug 8946: corrections in inc files for UNIMARC coded fields advanced search In subtypes_unimarc.inc files for opac and staff interface, this patch : - fix 1 wrong code (Frequency-code:i = Other should be z) - fix the label "Feschrift Ind." => "Literary genre" - add some values for Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g) - fix a few typos - change the order of some values (u values) To test, check if the new values are visible in the opac and staff interface. M. Saby
String changes. Will hold for post-3.10.0.
Created attachment 13415 [details] [review] Bug 8946: corrections in inc files for UNIMARC coded fields advanced search In subtypes_unimarc.inc files for opac and staff interface, this patch - fix 1 wrong code (Frequency-code:i = Other should be z) - fix the label "Feschrift Ind." to "Literary genre" - add some values for Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g) - fix a few typos - change the order of some values (u values) To test, check if the new values are visible in the opac and staff interface. Signed-off-by: Mason James <mtj@kohaaloha.com>
(In reply to comment #3) > Created attachment 13415 [details] [review] > Bug 8946: corrections in inc files for UNIMARC coded fields advanced search > > To test, check if the new values are visible in the opac and staff interface. > > Signed-off-by: Mason James <mtj@kohaaloha.com> verified new values are visible in opac and staff interface
QA comment: * despite it's size, this patch is really small * template only * passes koha-qa.pl
Created attachment 13782 [details] [review] Bug 8946: corrections in inc files for UNIMARC coded fields advanced search In subtypes_unimarc.inc files for opac and staff interface, this patch - fix 1 wrong code (Frequency-code:i = Other should be z) - fix the label "Feschrift Ind." to "Literary genre" - add some values for Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g) - fix a few typos - change the order of some values (u values) To test, check if the new values are visible in the opac and staff interface. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch has been pushed to master.
Bugfix, mixed the string freeze for 3.10.0, pushed to 3.10.x will be in 3.10.1
Pushed to 3.8.x, will be in 3.8.8
There is a typo in my patch. I am making a followup. M. Saby
Created attachment 14620 [details] [review] letter v between 2 option tag In HTML code generated for advanced search, a useless "v" letter is visible between 2 <option> tag. This patch suppress "v" letter is outside <option> markup (and cosmetic change : lowercase "Adult" in public types) To test : check HTML code generated by advanced search. M. Saby
I imagine you'll need to submit that as a new bug with the new patch as the current patch has already been pushed.. It should get signed off and pushed very quickly though if it's a single character change.
Thank you. The RM confirmed : "Yes please. The way to set the status back to "Needs signoff" is to reset it to "ASSIGNED" first, then switch it to "Needs signoff," but one of my new policies is that follow-ups must be done on new bugs once a patch has been pushed to master. Regards, Jared" So I will make a new bug M. Saby