Bug 8968 - JavaScript String not translatable
Summary: JavaScript String not translatable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: translate.koha-community.org (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Frédéric Demians
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 08:05 UTC by Frédéric Demians
Modified: 2013-12-05 20:01 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 8968 "Add to cart" translatable on OPAC result page (1.15 KB, patch)
2012-10-25 08:09 UTC, Frédéric Demians 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8968 "Add to cart" translatable on OPAC result page (1.25 KB, patch)
2012-10-25 18:31 UTC, Owen Leonard 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Demians 2012-10-25 08:05:23 UTC 
This is an omnibus bug, where to attach patch fixing strings in JavaScript code which are not translatable since there are not surrounded with _( ).
Comment 1 Frédéric Demians 2012-10-25 08:09:30 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-10-25 18:31:46 UTC 
Created attachment 13061 [details] [review]
[SIGNED-OFF] Bug 8968 "Add to cart" translatable on OPAC result page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2012-11-13 14:53:01 UTC 
Simple and logical patch.
Marked as Passed QA.
Comment 4 Jared Camins-Esakov 2012-11-13 15:01:30 UTC 
This patch has been pushed to master.
Comment 5 Chris Cormack 2012-11-13 21:59:43 UTC 
Pushed to 3.8.x, will be in 3.8.7
Comment 6 Paul Poulain 2012-11-16 17:35:22 UTC 
Patch pushed to branch 3.10.x
Comment 7 Liz Rea 2012-11-28 01:46:41 UTC 

Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. 

Thanks!